Remove javax.annotation Usage

Closes gh-9415

Author: jzheaux

ldap/src/integration-test/java/org/springframework/security/ldap/ApacheDsContainerConfig.java

@@ -16,8 +16,7 @@
 
 package org.springframework.security.ldap;
 
-import javax.annotation.PreDestroy;
-
+import org.springframework.beans.factory.DisposableBean;
 import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.Configuration;
 import org.springframework.ldap.core.ContextSource;
@@ -27,7 +26,7 @@
  * @author Eddú Meléndez
  */
 @Configuration
-public class ApacheDsContainerConfig {
+public class ApacheDsContainerConfig implements DisposableBean {
 
 	private ApacheDSContainer container;
 
@@ -44,8 +43,8 @@ ContextSource contextSource(ApacheDSContainer ldapContainer) throws Exception {
 				"ldap://127.0.0.1:" + ldapContainer.getLocalPort() + "/dc=springframework,dc=org");
 	}
 
-	@PreDestroy
-	void shutdown() {
+	@Override
+	public void destroy() throws Exception {
 		this.container.stop();
 	}
 

ldap/src/integration-test/java/org/springframework/security/ldap/server/UnboundIdContainerLdifTests.java

@@ -16,11 +16,10 @@
 
 package org.springframework.security.ldap.server;
 
-import javax.annotation.PreDestroy;
-
 import org.junit.After;
 import org.junit.Test;
 
+import org.springframework.beans.factory.DisposableBean;
 import org.springframework.context.annotation.AnnotationConfigApplicationContext;
 import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.Configuration;
@@ -92,7 +91,7 @@ public void unboundIdContainerWhenWildcardLdifNotFoundThenProceeds() {
 	}
 
 	@Configuration
-	static class CustomLdifConfig {
+	static class CustomLdifConfig implements DisposableBean {
 
 		private UnboundIdContainer container = new UnboundIdContainer("dc=springframework,dc=org",
 				"classpath:test-server.ldif");
@@ -109,15 +108,15 @@ ContextSource contextSource(UnboundIdContainer container) {
 					"ldap://127.0.0.1:" + container.getPort() + "/dc=springframework,dc=org");
 		}
 
-		@PreDestroy
-		void shutdown() {
+		@Override
+		public void destroy() throws Exception {
 			this.container.stop();
 		}
 
 	}
 
 	@Configuration
-	static class WildcardLdifConfig {
+	static class WildcardLdifConfig implements DisposableBean {
 
 		private UnboundIdContainer container = new UnboundIdContainer("dc=springframework,dc=org",
 				"classpath*:test-server.ldif");
@@ -134,15 +133,15 @@ ContextSource contextSource(UnboundIdContainer container) {
 					"ldap://127.0.0.1:" + container.getPort() + "/dc=springframework,dc=org");
 		}
 
-		@PreDestroy
-		void shutdown() {
+		@Override
+		public void destroy() throws Exception {
 			this.container.stop();
 		}
 
 	}
 
 	@Configuration
-	static class MalformedLdifConfig {
+	static class MalformedLdifConfig implements DisposableBean {
 
 		private UnboundIdContainer container = new UnboundIdContainer("dc=springframework,dc=org",
 				"classpath:test-server-malformed.txt");
@@ -153,15 +152,15 @@ UnboundIdContainer ldapContainer() {
 			return this.container;
 		}
 
-		@PreDestroy
-		void shutdown() {
+		@Override
+		public void destroy() throws Exception {
 			this.container.stop();
 		}
 
 	}
 
 	@Configuration
-	static class MissingLdifConfig {
+	static class MissingLdifConfig implements DisposableBean {
 
 		private UnboundIdContainer container = new UnboundIdContainer("dc=springframework,dc=org",
 				"classpath:does-not-exist.ldif");
@@ -172,15 +171,15 @@ UnboundIdContainer ldapContainer() {
 			return this.container;
 		}
 
-		@PreDestroy
-		void shutdown() {
+		@Override
+		public void destroy() throws Exception {
 			this.container.stop();
 		}
 
 	}
 
 	@Configuration
-	static class WildcardNoLdifConfig {
+	static class WildcardNoLdifConfig implements DisposableBean {
 
 		private UnboundIdContainer container = new UnboundIdContainer("dc=springframework,dc=org",
 				"classpath*:*.test.ldif");
@@ -191,8 +190,8 @@ UnboundIdContainer ldapContainer() {
 			return this.container;
 		}
 
-		@PreDestroy
-		void shutdown() {
+		@Override
+		public void destroy() throws Exception {
 			this.container.stop();
 		}
 

ldap/src/integration-test/java/org/springframework/security/ldap/userdetails/LdapUserDetailsManagerModifyPasswordTests.java

@@ -16,12 +16,11 @@
 
 package org.springframework.security.ldap.userdetails;
 
-import javax.annotation.PreDestroy;
-
 import org.junit.Before;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 
+import org.springframework.beans.factory.DisposableBean;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.Configuration;
@@ -81,7 +80,7 @@ public void changePasswordWhenOldPasswordIsCorrectThenPasses() {
 	}
 
 	@Configuration
-	static class UnboundIdContainerConfiguration {
+	static class UnboundIdContainerConfiguration implements DisposableBean {
 
 		private UnboundIdContainer container = new UnboundIdContainer("dc=springframework,dc=org",
 				"classpath:test-server.ldif");
@@ -98,8 +97,8 @@ ContextSource contextSource(UnboundIdContainer container) {
 					"ldap://127.0.0.1:" + container.getPort() + "/dc=springframework,dc=org");
 		}
 
-		@PreDestroy
-		void shutdown() {
+		@Override
+		public void destroy() throws Exception {
 			this.container.stop();
 		}