Skip to content

Commit db95f6d

Browse files
Merge branch '5.6.x' into 5.7.x
Closes gh-11767
2 parents 517631e + 40abf87 commit db95f6d

File tree

3 files changed

+38
-0
lines changed

3 files changed

+38
-0
lines changed

build.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -204,6 +204,7 @@ tasks.register('checkSamples') {
204204
includeCheckRemote {
205205
repository = 'spring-projects/spring-security-samples'
206206
ref = samplesBranch
207+
buildScan = true
207208
if (project.hasProperty("samplesInitScript")) {
208209
initScripts = [samplesInitScript]
209210
projectProperties = ["localRepositoryPath": localRepositoryPath, "springSecurityVersion": project.version]

buildSrc/src/main/groovy/io/spring/gradle/convention/IncludeCheckRemotePlugin.groovy

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ class IncludeCheckRemotePlugin implements Plugin<Project> {
3939
it.dependsOn 'includeRepo'
4040
it.dir = includeRepoTask.get().outputDirectory
4141
it.tasks = extension.getTasks()
42+
it.startParameter.buildScan = extension.getBuildScan()
4243
extension.getInitScripts().forEach {script ->
4344
it.startParameter.addInitScript(new File(script))
4445
}
@@ -75,6 +76,11 @@ class IncludeCheckRemotePlugin implements Plugin<Project> {
7576
*/
7677
Map<String, String> projectProperties = [:]
7778

79+
/**
80+
* Whether the Build Scan should be published
81+
*/
82+
boolean buildScan = false
83+
7884
}
7985

8086
}

buildSrc/src/test/java/io/spring/gradle/convention/IncludeCheckRemotePluginTest.java

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,4 +145,35 @@ void applyWhenNoExtensionPropertiesThenRegisterTasks() {
145145
assertThat(checkRemote).isNotNull();
146146
}
147147

148+
@Test
149+
void applyWhenNoBuildScanSpecifiedThenRegisterCheckRemoteTaskWithBuildScanFalse() {
150+
this.rootProject = ProjectBuilder.builder().build();
151+
this.rootProject.getPluginManager().apply(IncludeCheckRemotePlugin.class);
152+
this.rootProject.getExtensions().configure(IncludeCheckRemotePlugin.IncludeCheckRemoteExtension.class,
153+
(includeCheckRemoteExtension) -> {
154+
includeCheckRemoteExtension.setProperty("repository", "my-project/my-repository");
155+
includeCheckRemoteExtension.setProperty("ref", "main");
156+
});
157+
158+
GradleBuild checkRemote = (GradleBuild) this.rootProject.getTasks().named("checkRemote").get();
159+
assertThat(checkRemote).isNotNull();
160+
assertThat(checkRemote.getStartParameter().isBuildScan()).isFalse();
161+
}
162+
163+
@Test
164+
void applyWhenBuildScanTrueThenRegisterCheckRemoteTaskWithBuildScanTrue() {
165+
this.rootProject = ProjectBuilder.builder().build();
166+
this.rootProject.getPluginManager().apply(IncludeCheckRemotePlugin.class);
167+
this.rootProject.getExtensions().configure(IncludeCheckRemotePlugin.IncludeCheckRemoteExtension.class,
168+
(includeCheckRemoteExtension) -> {
169+
includeCheckRemoteExtension.setProperty("repository", "my-project/my-repository");
170+
includeCheckRemoteExtension.setProperty("ref", "main");
171+
includeCheckRemoteExtension.setProperty("buildScan", true);
172+
});
173+
174+
GradleBuild checkRemote = (GradleBuild) this.rootProject.getTasks().named("checkRemote").get();
175+
assertThat(checkRemote).isNotNull();
176+
assertThat(checkRemote.getStartParameter().isBuildScan()).isTrue();
177+
}
178+
148179
}

0 commit comments

Comments
 (0)