Skip to content

GenerateOneTimeTokenFilter should not attempt to generate a token with a null token request #18088

@jzheaux

Description

@jzheaux

Related to #16291

GenerateOneTimeTokenFilter attempts to generate a token, even when the token generation request is null:

		GenerateOneTimeTokenRequest generateRequest = this.requestResolver.resolve(request);
		OneTimeToken ott = this.tokenService.generate(generateRequest);
		if (generateRequest == null) {
			filterChain.doFilter(request, response);
			return;
		}

Given that the filter becomes a no-op if generateRequest is null, then it's clearer and less work if tokenService.generate is invoked after the if statement.

Metadata

Metadata

Assignees

Labels

in: webAn issue in web modules (web, webmvc)type: bugA general bug

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions