Replace "shameless coverage code" in SecurityNamespaceHandlerTests with meaningful tests #17689
+14
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
added
in: config
jzheaux
changed the title
|
Thanks, @seongm1n! Will you please squash your commits and also update your commit title to be: The reason is that you are quoting something in the codebase. In this way, it's clear that no one is casting shade on someone else's code. Alternatively, you can say: or similar. |
Signed-off-by: seongm1n <[email protected]>
|
Thanks for the feedback! I've squashed the commits and updated the commit message as requested. |
jzheaux
added a commit
that referenced
this pull request
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes "shameless class coverage stats boosting" code that created
meaningless anonymous class instances just to increase coverage metrics.
Replaces with proper tests that validate BeanIds and Elements constants
are accessible and not empty.
Changes: