test coverage

Author: nfawcett

spring-session-data-redis/src/integration-test/java/org/springframework/session/data/redis/RedisIndexedSessionRepositoryITests.java

@@ -17,6 +17,7 @@
 package org.springframework.session.data.redis;
 
 import java.nio.charset.StandardCharsets;
+import java.time.Duration;
 import java.util.Map;
 import java.util.UUID;
 import java.util.concurrent.TimeUnit;
@@ -151,6 +152,22 @@ void saveThenSaveSessionKeyAndShadowKeyWith5MinutesDifference() {
 		assertThat(differenceInSeconds).isEqualTo(300);
 	}
 
+
+	@Test
+	void saveNonExpiringThenSaveSessionKeyAndShadowKeyWithNoDifference() {
+		RedisSession toSave = this.repository.createSession();
+		String expectedAttributeName = "a";
+		String expectedAttributeValue = "b";
+		toSave.setAttribute(expectedAttributeName, expectedAttributeValue);
+		toSave.setMaxInactiveInterval(Duration.ofMillis(-1));
+
+		this.repository.save(toSave);
+
+		Long sessionKeyExpire = this.redis.getExpire("RedisIndexedSessionRepositoryITests:sessions:" + toSave.getId(),
+				TimeUnit.SECONDS);
+		assertThat(sessionKeyExpire).isEqualTo(-1);
+	}
+
 	@Test
 	void putAllOnSingleAttrDoesNotRemoveOld() {
 		RedisSession toSave = this.repository.createSession();

spring-session-data-redis/src/test/java/org/springframework/session/data/redis/RedisIndexedSessionRepositoryTests.java

@@ -271,6 +271,22 @@ void saveSetAttribute() {
 				map(RedisIndexedSessionRepository.getSessionAttrNameKey(attrName), session.getAttribute(attrName)));
 	}
 
+	@Test
+	void saveNonExpiring() {
+		RedisSession session = this.redisRepository.new RedisSession(new MapSession(), false);
+		session.setMaxInactiveInterval(Duration.ofSeconds(-1));
+
+		given(this.redisOperations.<String, Object>boundHashOps(anyString())).willReturn(this.boundHashOperations);
+		given(this.redisOperations.boundSetOps(anyString())).willReturn(this.boundSetOperations);
+		given(this.redisOperations.boundValueOps(anyString())).willReturn(this.boundValueOperations);
+
+		this.redisRepository.save(session);
+
+		verify(this.boundHashOperations, never()).expire(-1, TimeUnit.SECONDS);
+		assertThat(getDelta())
+				.isEqualTo(map(RedisSessionMapper.MAX_INACTIVE_INTERVAL_KEY, -1));
+	}
+
 	@Test
 	void saveRemoveAttribute() {
 		String attrName = "attrName";