Skip to content

Commit 161276d

Browse files
committed
move set of jakarta annotations to constants class
1 parent 4588b08 commit 161276d

File tree

2 files changed

+7
-10
lines changed

2 files changed

+7
-10
lines changed

headless-services/spring-boot-language-server/src/main/java/org/springframework/ide/vscode/boot/java/Annotations.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,5 +114,11 @@ public class Annotations {
114114
"org.aspectj.lang.annotation.AfterThrowing", "AfterThrowing",
115115
"org.aspectj.lang.annotation.DeclareParents", "DeclareParents"
116116
);
117+
118+
public static final Set<String> JAKARTA_ANNOTATIONS = Set.of(
119+
Annotations.RESOURCE_JAKARTA, Annotations.INJECT_JAKARTA, Annotations.NAMED_JAKARTA,
120+
Annotations.RESOURCE_JAVAX, Annotations.INJECT_JAVAX, Annotations.NAMED_JAVAX
121+
);
122+
117123

118124
}

headless-services/spring-boot-language-server/src/main/java/org/springframework/ide/vscode/boot/java/utils/SpringIndexerJava.java

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -114,11 +114,6 @@ public class SpringIndexerJava implements SpringIndexer {
114114
private final SpringIndexerJavaDependencyTracker dependencyTracker = new SpringIndexerJavaDependencyTracker();
115115
private final BiFunction<AtomicReference<TextDocument>, BiConsumer<String, Diagnostic>, IProblemCollector> problemCollectorCreator;
116116

117-
private final Set<String> jakartaAnnnotations = Set.of(
118-
Annotations.RESOURCE_JAKARTA, Annotations.INJECT_JAKARTA, Annotations.NAMED_JAKARTA,
119-
Annotations.RESOURCE_JAVAX, Annotations.INJECT_JAVAX, Annotations.NAMED_JAVAX
120-
);
121-
122117

123118
public SpringIndexerJava(SymbolHandler symbolHandler, AnnotationHierarchyAwareLookup<SymbolProvider> symbolProviders, IndexCache cache,
124119
JavaProjectFinder projectFimder, ProgressService progressService, JdtReconciler jdtReconciler,
@@ -861,7 +856,7 @@ private WorkspaceSymbol provideDefaultSymbol(Annotation node, final SpringIndexe
861856
String qualifiedName = type.getQualifiedName();
862857
if (qualifiedName != null
863858
&& ((qualifiedName.startsWith("org.springframework") && !qualifiedName.startsWith("org.springframework.lang"))
864-
|| isJakartaAnnotationWithDefaultSymbol(qualifiedName))) {
859+
|| Annotations.JAKARTA_ANNOTATIONS.contains(qualifiedName))) {
865860
TextDocument doc = DocumentUtils.getTempTextDocument(context.getDocURI(), context.getDocRef(), context.getContent());
866861
return DefaultSymbolProvider.provideDefaultSymbol(node, doc);
867862
}
@@ -877,10 +872,6 @@ private WorkspaceSymbol provideDefaultSymbol(Annotation node, final SpringIndexe
877872
return null;
878873
}
879874

880-
private boolean isJakartaAnnotationWithDefaultSymbol(String qualifiedName) {
881-
return jakartaAnnnotations.contains(qualifiedName);
882-
}
883-
884875
public static ASTParserCleanupEnabled createParser(IJavaProject project, AnnotationHierarchies annotationHierarchies, boolean ignoreMethodBodies) throws Exception {
885876
String[] classpathEntries = getClasspathEntries(project);
886877
String[] sourceEntries = getSourceEntries(project);

0 commit comments

Comments
 (0)