fix test to deal correctly with null values coming back from document highlight requests

martinlippert · martinlippert · commit 39fb0b4ecda7 · 2024-10-09T13:17:14.000+02:00
diff --git a/headless-services/commons/language-server-test-harness/src/main/java/org/springframework/ide/vscode/languageserver/testharness/Editor.java b/headless-services/commons/language-server-test-harness/src/main/java/org/springframework/ide/vscode/languageserver/testharness/Editor.java
@@ -248,7 +248,13 @@ public void assertDocumentHighlights(String afterString, DocumentHighlight... ex
 			pos += afterString.length();
 		}
 		List<? extends DocumentHighlight> actual = harness.getDocumentHighlights(doc.getId(), doc.toPosition(pos));
-		assertEquals(ImmutableList.copyOf(expected), actual);
+		
+		if (actual == null) {
+			assertTrue(expected == null || expected.length == 0);
+		}
+		else {
+			assertEquals(ImmutableList.copyOf(expected), actual);
+		}
 	}
 
 	/**

Original file line number	Diff line number	Diff line change
`@@ -248,7 +248,13 @@ public void assertDocumentHighlights(String afterString, DocumentHighlight... ex`
`248`	`248`	`pos += afterString.length();`
`249`	`249`	`}`
`250`	`250`	`List<? extends DocumentHighlight> actual = harness.getDocumentHighlights(doc.getId(), doc.toPosition(pos));`
`251`		`- assertEquals(ImmutableList.copyOf(expected), actual);`
	`251`	`+`
	`252`	`+ if (actual == null) {`
	`253`	`+ assertTrue(expected == null \|\| expected.length == 0);`
	`254`	`+ }`
	`255`	`+ else {`
	`256`	`+ assertEquals(ImmutableList.copyOf(expected), actual);`
	`257`	`+ }`
`252`	`258`	`}`
`253`	`259`
`254`	`260`	`/**`