GH-1521: removed old prototype around detecting differences between different runs of the same project

Fixes GH-1521

Author: martinlippert

eclipse-language-servers/org.springframework.tooling.boot.ls/src/org/springframework/tooling/boot/ls/Constants.java

@@ -28,8 +28,6 @@ public class Constants {
 	public static final String PREF_XML_CONFIGS_HYPERLINKS = "boot-java.support-spring-xml-config.hyperlinks";
 	public static final String PREF_XML_CONFIGS_CONTENT_ASSIST = "boot-java.support-spring-xml-config.content-assist";
 
-	public static final String PREF_CHANGE_DETECTION = "boot-java.change-detection.on";
-	
 	public static final String PREF_JAVA_RECONCILE = "boot-java.java.reconcile";
 
 	public static final String PREF_REWRITE_RECIPE_FILTERS = "boot-java.rewrite.recipe-filters";

eclipse-language-servers/org.springframework.tooling.boot.ls/src/org/springframework/tooling/boot/ls/DelegatingStreamConnectionProvider.java

@@ -180,7 +180,6 @@ private void sendConfiguration() {
 		Map<String, Object> liveInformation = new HashMap<>();
 		Map<String, Object> liveInformationFetchData = new HashMap<>();
 		Map<String, Object> supportXML = new HashMap<>();
-		Map<String, Object> bootChangeDetection = new HashMap<>();
 		Map<String, Object> scanTestJavaSources = new HashMap<>();
 		Map<String, Object> javaSettings = new HashMap<>();
 		Map<String, Object> javaCompletionSettings = new HashMap<>();
@@ -197,7 +196,6 @@ private void sendConfiguration() {
 		supportXML.put("scan-folders", preferenceStore.getString(Constants.PREF_XML_CONFIGS_SCAN_FOLDERS));
 		supportXML.put("hyperlinks", preferenceStore.getString(Constants.PREF_XML_CONFIGS_HYPERLINKS));
 		supportXML.put("content-assist", preferenceStore.getString(Constants.PREF_XML_CONFIGS_CONTENT_ASSIST));
-		bootChangeDetection.put("on", preferenceStore.getBoolean(Constants.PREF_CHANGE_DETECTION));
 		scanTestJavaSources.put("on", preferenceStore.getBoolean(Constants.PREF_SCAN_JAVA_TEST_SOURCES));
 
 		javaCompletionSettings.put("inject-bean", preferenceStore.getBoolean(Constants.PREF_COMPLETION_JAVA_INJECT_BEAN));
@@ -209,9 +207,7 @@ private void sendConfiguration() {
 		bootJavaObj.put("jpql", preferenceStore.getBoolean(Constants.PREF_JPQL));
 		bootJavaObj.put("live-information", liveInformation);
 		bootJavaObj.put("support-spring-xml-config", supportXML);
-		bootJavaObj.put("change-detection", bootChangeDetection);
 		bootJavaObj.put("scan-java-test-sources", scanTestJavaSources);
-		bootJavaObj.put("change-detection", bootChangeDetection);
 		bootJavaObj.put("java", javaSettings);
 		bootJavaObj.put("remote-apps", getAllRemoteApps());
 		bootJavaObj.put("modulith-project-tracking", preferenceStore.getBoolean(Constants.PREF_MODULITH));

eclipse-language-servers/org.springframework.tooling.boot.ls/src/org/springframework/tooling/boot/ls/prefs/BootJavaPreferencesPage.java

@@ -41,8 +41,6 @@ protected void createFieldEditors() {
 		addField(new BooleanFieldEditor(Constants.PREF_START_LS_EARLY, "Start Language Server at startup if Spring Boot is a dependency", fieldEditorParent));
 		addField(new BooleanFieldEditor(Constants.PREF_SCAN_JAVA_TEST_SOURCES, "Scan Java test sources", fieldEditorParent));
 
-		addField(new BooleanFieldEditor(Constants.PREF_CHANGE_DETECTION, "Live Boot Change Detection", fieldEditorParent));
-
 		// JPQL Support switch
 		addField(new BooleanFieldEditor(Constants.PREF_JPQL, "JPA Query language support", fieldEditorParent));
 

eclipse-language-servers/org.springframework.tooling.boot.ls/src/org/springframework/tooling/boot/ls/prefs/PrefsInitializer.java

@@ -40,8 +40,6 @@ public void initializeDefaultPreferences() {
 		preferenceStore.setDefault(Constants.PREF_XML_CONFIGS_CONTENT_ASSIST, true);
 		preferenceStore.setDefault(Constants.PREF_XML_CONFIGS_SCAN_FOLDERS, "src/main");
 
-		preferenceStore.setDefault(Constants.PREF_CHANGE_DETECTION, false);
-
 		preferenceStore.setDefault(Constants.PREF_SCAN_JAVA_TEST_SOURCES, false);
 
 		preferenceStore.setDefault(Constants.PREF_JAVA_RECONCILE, true);

headless-services/spring-boot-language-server/src/main/java/org/springframework/ide/vscode/boot/app/BootJavaConfig.java

@@ -131,11 +131,6 @@ public String[] xmlBeansFoldersToScan() {
 		return cleanedFolders.toArray(new String[cleanedFolders.size()]);
 	}
 
-	public boolean isChangeDetectionEnabled() {
-		Boolean enabled = settings.getBoolean("boot-java", "change-detection", "on");
-		return enabled != null && enabled.booleanValue();
-	}
-
 	public boolean isSpelExpressionValidationEnabled() {
 		Toggle categorySwitch = SpringProblemCategories.SPEL.getToggle();
 		return isProblemCategoryEnabled(categorySwitch);

headless-services/spring-boot-language-server/src/main/java/org/springframework/ide/vscode/boot/java/BootJavaLanguageServerComponents.java

@@ -10,7 +10,6 @@
  *******************************************************************************/
 package org.springframework.ide.vscode.boot.java;
 
-import java.time.Duration;
 import java.util.ArrayList;
 import java.util.Collection;
 import java.util.HashMap;
@@ -63,7 +62,6 @@
 import org.springframework.ide.vscode.boot.java.requestmapping.WebfluxRouteHighlightProdivder;
 import org.springframework.ide.vscode.boot.java.spel.SpelSemanticTokens;
 import org.springframework.ide.vscode.boot.java.utils.CompilationUnitCache;
-import org.springframework.ide.vscode.boot.java.utils.SpringLiveChangeDetectionWatchdog;
 import org.springframework.ide.vscode.boot.java.value.ValueHoverProvider;
 import org.springframework.ide.vscode.boot.java.value.ValuePropertyReferencesProvider;
 import org.springframework.ide.vscode.boot.metadata.SpringPropertyIndexProvider;
@@ -111,7 +109,6 @@ public class BootJavaLanguageServerComponents implements LanguageServerComponent
 
 	private final SpringProcessConnectorService liveDataService;
 
-	private final SpringLiveChangeDetectionWatchdog liveChangeDetectionWatchdog;
 	private final ProjectObserver projectObserver;
 	private final CompilationUnitCache cuCache;
 	private final ResponseModifier responseModifier;
@@ -179,14 +176,6 @@ public BootJavaLanguageServerComponents(ApplicationContext appContext) {
 		workspaceService.onWorkspaceSymbol(new BootJavaWorkspaceSymbolHandler(springSymbolIndex,
 				new LiveAppURLSymbolProvider(liveDataProvider)));
 
-		liveChangeDetectionWatchdog = new SpringLiveChangeDetectionWatchdog(
-				this,
-				server,
-				serverParams.projectObserver,
-				projectFinder,
-				Duration.ofSeconds(5),
-				sourceLinks);
-		
 		spelSemanticTokens = appContext.getBean(SpelSemanticTokens.class);
 
 		codeLensHandler = createCodeLensEngine(springIndex, projectFinder, server, spelSemanticTokens);
@@ -211,14 +200,6 @@ public BootJavaLanguageServerComponents(ApplicationContext appContext) {
 			// live information data fetch params
 			liveDataService.setMaxRetryCount(config.getLiveInformationFetchDataMaxRetryCount());
 			liveDataService.setRetryDelayInSeconds(config.getLiveInformationFetchDataRetryDelayInSeconds());
-
-			// live change detection watchdog
-			if (config.isChangeDetectionEnabled()) {
-				liveChangeDetectionWatchdog.enableHighlights();
-			}
-			else {
-				liveChangeDetectionWatchdog.disableHighlights();
-			}
 
 			log.info("update live process tracker settings - done");
 		});
@@ -255,11 +236,9 @@ public Optional<DocumentSymbolHandler> getDocumentSymbolProvider() {
 	}
 
 	private void initialized() {
-		this.liveChangeDetectionWatchdog.start();
 	}
 
 	private void shutdown() {
-		this.liveChangeDetectionWatchdog.shutdown();
 		this.cuCache.dispose();
 	}