Skip to content

Commit 7b83098

Browse files
committed
filed and added corresponding JDT parser issues for disabled test cases around code completion difficulties
1 parent 4e7dccb commit 7b83098

File tree

2 files changed

+14
-19
lines changed

2 files changed

+14
-19
lines changed

headless-services/spring-boot-language-server/src/test/java/org/springframework/ide/vscode/boot/java/conditionals/test/ConditionalOnPropertyCompletionTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ public void testConditionalOnPropertyCompletionForPrefix() throws Exception {
189189
}
190190

191191
@Test
192-
@Disabled
192+
@Disabled // https://github.com/eclipse-jdt/eclipse.jdt.core/issues/3260
193193
public void testConditionalOnPropertyCompletionWithPrefixAndAttributeWithNameAttribute() throws Exception {
194194
List<CompletionItem> completions = getCompletions("@ConditionalOnProperty(prefix = \"else\", name=<*>)");
195195
assertEquals(1, completions.size());
@@ -210,7 +210,7 @@ public void testConditionalOnPropertyCompletionWithPrefixAndAttributeWithNameAtt
210210
}
211211

212212
@Test
213-
@Disabled
213+
@Disabled // https://github.com/eclipse-jdt/eclipse.jdt.core/issues/3419
214214
public void testConditionalOnPropertyCompletionWithEmptyPrefixAndEmptyNameAttribute() throws Exception {
215215
List<CompletionItem> completions = getCompletions("@ConditionalOnProperty(prefix = , name = <*>)");
216216
assertEquals(3, completions.size());
@@ -221,7 +221,7 @@ public void testConditionalOnPropertyCompletionWithEmptyPrefixAndEmptyNameAttrib
221221
}
222222

223223
@Test
224-
@Disabled
224+
@Disabled // https://github.com/eclipse-jdt/eclipse.jdt.core/issues/3419
225225
public void testConditionalOnPropertyCompletionWithEmptyPrefixAndEmptyNameAttributeInQuotes() throws Exception {
226226
List<CompletionItem> completions = getCompletions("@ConditionalOnProperty(prefix = , name = \"<*>\")");
227227
assertEquals(3, completions.size());

headless-services/spring-boot-language-server/src/test/java/org/springframework/ide/vscode/boot/java/value/test/ValueCompletionTest.java

Lines changed: 11 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -288,10 +288,8 @@ void testPlainPrefixCompletion() throws Exception {
288288
assertClasspathCompletions();
289289
}
290290

291-
// The parser removes the (spring.) piece from the AST in this case, so there is no way
292-
// to clearly identify this case
293291
@Test
294-
@Disabled
292+
@Disabled // https://github.com/eclipse-jdt/eclipse.jdt.core/issues/3420
295293
void testComplexPrefixCompletionParamNameCursorRightAfterDot() throws Exception {
296294
prepareCase("@Value(\"onField\")", "@Value(spring.<*>)");
297295

@@ -321,19 +319,16 @@ void testPrefixCompletionWithParamName() throws Exception {
321319
assertClasspathCompletions();
322320
}
323321

324-
// The parser removes the (spring.) piece from the AST in this case, so there is no way
325-
// to clearly identify this case
326-
//
327-
// @Test
328-
// void testPrefixCompletionWithParamNameCursorRightAfterDot() throws Exception {
329-
// prepareCase("@Value(\"onField\")", "@Value(value=spring.<*>)");
330-
// prepareDefaultIndexData();
331-
//
332-
// assertPropertyCompletions(
333-
// "@Value(value=\"${spring.prop1}\"<*>)");
334-
//
335-
// assertClasspathCompletions();
336-
// }
322+
@Test
323+
@Disabled // https://github.com/eclipse-jdt/eclipse.jdt.core/issues/3421
324+
void testPrefixCompletionWithParamNameCursorRightAfterDot() throws Exception {
325+
prepareCase("@Value(\"onField\")", "@Value(value=spring.<*>)");
326+
327+
assertPropertyCompletions(
328+
"@Value(value=\"${spring.prop1}\"<*>)");
329+
330+
assertClasspathCompletions();
331+
}
337332

338333
@Test
339334
void testComplexPrefixCompletionWithParamName() throws Exception {

0 commit comments

Comments
 (0)