Skip to content

Commit d1bc241

Browse files
committed
No rewrite-gradle
1 parent 8aef203 commit d1bc241

File tree

6 files changed

+19
-221
lines changed

6 files changed

+19
-221
lines changed

headless-services/commons/commons-rewrite/pom.xml

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -36,14 +36,6 @@
3636
<groupId>org.openrewrite</groupId>
3737
<artifactId>rewrite-maven</artifactId>
3838
</dependency>
39-
<dependency>
40-
<groupId>org.openrewrite</groupId>
41-
<artifactId>rewrite-groovy</artifactId>
42-
</dependency>
43-
<dependency>
44-
<groupId>org.openrewrite</groupId>
45-
<artifactId>rewrite-gradle</artifactId>
46-
</dependency>
4739
<dependency>
4840
<groupId>org.openrewrite</groupId>
4941
<artifactId>rewrite-yaml</artifactId>
@@ -72,15 +64,6 @@
7264
<artifactId>rewrite-java-25</artifactId>
7365
<scope>runtime</scope>
7466
</dependency>
75-
<dependency>
76-
<groupId>org.openrewrite.gradle.tooling</groupId>
77-
<artifactId>model</artifactId>
78-
</dependency>
79-
<dependency>
80-
<groupId>org.gradle</groupId>
81-
<artifactId>gradle-tooling-api</artifactId>
82-
<scope>runtime</scope>
83-
</dependency>
8467
<dependency>
8568
<groupId>org.eclipse.jgit</groupId>
8669
<artifactId>org.eclipse.jgit</artifactId>

headless-services/commons/commons-rewrite/src/main/java/org/springframework/ide/vscode/commons/rewrite/gradle/GradleIJavaProjectParser.java

Lines changed: 0 additions & 94 deletions
This file was deleted.

headless-services/commons/commons-rewrite/src/test/java/org/springframework/ide/vscode/commons/rewrite/gradle/GradleIJavaProjectParserTest.java

Lines changed: 0 additions & 91 deletions
This file was deleted.

headless-services/spring-boot-language-server/src/main/java/org/springframework/ide/vscode/boot/java/rewrite/RewriteRecipeRepository.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@
5151
import org.springframework.ide.vscode.commons.languageserver.util.SimpleLanguageServer;
5252
import org.springframework.ide.vscode.commons.protocol.java.ProjectBuild;
5353
import org.springframework.ide.vscode.commons.rewrite.ORDocUtils;
54-
import org.springframework.ide.vscode.commons.rewrite.gradle.GradleIJavaProjectParser;
5554
import org.springframework.ide.vscode.commons.rewrite.java.ProjectParser;
5655
import org.springframework.ide.vscode.commons.rewrite.maven.MavenIJavaProjectParser;
5756
import org.springframework.ide.vscode.commons.util.text.TextDocument;
@@ -239,8 +238,6 @@ private static ProjectParser createRewriteProjectParser(IJavaProject jp, Functio
239238
case ProjectBuild.MAVEN_PROJECT_TYPE:
240239
MavenParser.Builder mavenParserBuilder = MavenParser.builder();
241240
return new MavenIJavaProjectParser(jp, JavaParser.fromJavaVersion(), inputProvider, mavenParserBuilder);
242-
case ProjectBuild.GRADLE_PROJECT_TYPE:
243-
return new GradleIJavaProjectParser(jp, JavaParser.fromJavaVersion(), inputProvider);
244241
default:
245242
throw new IllegalStateException("The project is neither Maven nor Gradle!");
246243
}

headless-services/spring-boot-language-server/src/main/java/org/springframework/ide/vscode/boot/java/rewrite/SpringBootUpgrade.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,13 @@
1717
import org.eclipse.lsp4j.TextDocumentIdentifier;
1818
import org.openrewrite.Recipe;
1919
import org.openrewrite.config.DeclarativeRecipe;
20-
import org.openrewrite.gradle.plugins.UpgradePluginVersion;
2120
import org.openrewrite.maven.UpgradeParentVersion;
2221
import org.springframework.ide.vscode.commons.Version;
2322
import org.springframework.ide.vscode.commons.java.IJavaProject;
2423
import org.springframework.ide.vscode.commons.java.SpringProjectUtil;
2524
import org.springframework.ide.vscode.commons.languageserver.java.JavaProjectFinder;
2625
import org.springframework.ide.vscode.commons.languageserver.util.SimpleLanguageServer;
26+
import org.springframework.ide.vscode.commons.protocol.java.ProjectBuild;
2727
import org.springframework.ide.vscode.commons.util.Assert;
2828

2929
import com.google.gson.JsonElement;
@@ -43,6 +43,8 @@ public SpringBootUpgrade(SimpleLanguageServer server, RewriteRecipeRepository re
4343
IJavaProject project = projectFinder.find(new TextDocumentIdentifier(uri)).orElse(null);
4444
Assert.isLegal(project != null, "No Spring Boot project found for uri: " + uri);
4545

46+
Assert.isLegal(project.getProjectBuild().getType() == ProjectBuild.MAVEN_PROJECT_TYPE, "Only Maven projects supported");
47+
4648
Version version = SpringProjectUtil.getDependencyVersion(project, SpringProjectUtil.SPRING_BOOT);
4749

4850
// Version upgrade is not supposed to work for patch version. Only for the major and minor versions.
@@ -69,8 +71,6 @@ private Recipe createUpgradeRecipe(Version version, Version targetVersion) {
6971
// patch version upgrade - treat as pom versions only upgrade
7072
recipe.getRecipeList().add(new org.openrewrite.maven.UpgradeDependencyVersion("org.springframework.boot", "*", version.getMajor() + "." + version.getMinor() + ".x", null, null, null));
7173
recipe.getRecipeList().add(new UpgradeParentVersion("org.springframework.boot", "spring-boot-starter-parent", version.getMajor() + "." + version.getMinor() + ".x", null, null));
72-
recipe.getRecipeList().add(new org.openrewrite.gradle.UpgradeDependencyVersion("org.springframework.boot", "*", version.getMajor() + "." + version.getMinor() + ".x", null));
73-
recipe.getRecipeList().add(new UpgradePluginVersion("org.springframework.boot", version.getMajor() + "." + version.getMinor() + ".x", null));
7474
}
7575

7676
if (recipe.getRecipeList().isEmpty()) {

headless-services/spring-boot-language-server/src/main/java/org/springframework/ide/vscode/boot/validation/generations/UpdateBootVersion.java

Lines changed: 16 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
import org.springframework.ide.vscode.commons.java.IJavaProject;
2929
import org.springframework.ide.vscode.commons.java.SpringProjectUtil;
3030
import org.springframework.ide.vscode.commons.languageserver.reconcile.DiagnosticSeverityProvider;
31+
import org.springframework.ide.vscode.commons.protocol.java.ProjectBuild;
3132

3233
import com.google.common.collect.ImmutableList;
3334

@@ -67,19 +68,21 @@ private Optional<Diagnostic> validateMajorVersion(IJavaProject javaProject, Vers
6768

6869
List<CodeAction> actions = new ArrayList<>(2);
6970

70-
bootUpgradeOpt.flatMap(bu -> bu.getNearestAvailableMinorVersion(latest)).map(targetVersion -> {
71-
Version upgradeVersion = Version.parse(targetVersion);
72-
if (javaProjectVersion.compareTo(upgradeVersion) >= 0) {
73-
return null;
74-
}
75-
CodeAction c = new CodeAction();
76-
c.setKind(CodeActionKind.QuickFix);
77-
c.setTitle("Upgrade to Spring Boot " + targetVersion + " (executes the full project conversion recipe from OpenRewrite)");
78-
String commandId = SpringBootUpgrade.CMD_UPGRADE_SPRING_BOOT;
79-
c.setCommand(new Command("Upgrade to Version " + targetVersion, commandId,
80-
ImmutableList.of(javaProject.getLocationUri().toASCIIString(), targetVersion, true)));
81-
return c;
82-
}).ifPresent(actions::add);
71+
if (javaProject.getProjectBuild().getType() == ProjectBuild.MAVEN_PROJECT_TYPE) {
72+
bootUpgradeOpt.flatMap(bu -> bu.getNearestAvailableMinorVersion(latest)).map(targetVersion -> {
73+
Version upgradeVersion = Version.parse(targetVersion);
74+
if (javaProjectVersion.compareTo(upgradeVersion) >= 0) {
75+
return null;
76+
}
77+
CodeAction c = new CodeAction();
78+
c.setKind(CodeActionKind.QuickFix);
79+
c.setTitle("Upgrade to Spring Boot " + targetVersion + " (executes the full project conversion recipe from OpenRewrite)");
80+
String commandId = SpringBootUpgrade.CMD_UPGRADE_SPRING_BOOT;
81+
c.setCommand(new Command("Upgrade to Version " + targetVersion, commandId,
82+
ImmutableList.of(javaProject.getLocationUri().toASCIIString(), targetVersion, true)));
83+
return c;
84+
}).ifPresent(actions::add);
85+
}
8386

8487
actions.add(openReleaseNotesCodeAction(latest));
8588

0 commit comments

Comments
 (0)