Eagerly initialize Netty4ClientHttpRequestFactory

Avoid a null SSLContext.

Closes gh-597

Author: mp911de

spring-vault-core/src/main/java/org/springframework/vault/client/ClientHttpRequestFactoryFactory.java

@@ -343,6 +343,9 @@ static ClientHttpRequestFactory usingNetty(ClientOptions options, SslConfigurati
 			requestFactory.setConnectTimeout(Math.toIntExact(options.getConnectionTimeout().toMillis()));
 			requestFactory.setReadTimeout(Math.toIntExact(options.getReadTimeout().toMillis()));
 
+			// eagerly initialize to ensure SSL context
+			requestFactory.afterPropertiesSet();
+
 			return requestFactory;
 		}
 

spring-vault-core/src/test/java/org/springframework/vault/client/ClientHttpRequestFactoryFactoryIntegrationTests.java

@@ -25,10 +25,12 @@
 import org.springframework.http.client.HttpComponentsClientHttpRequestFactory;
 import org.springframework.http.client.Netty4ClientHttpRequestFactory;
 import org.springframework.http.client.OkHttp3ClientHttpRequestFactory;
+import org.springframework.test.util.ReflectionTestUtils;
 import org.springframework.vault.client.ClientHttpRequestFactoryFactory.HttpComponents;
 import org.springframework.vault.client.ClientHttpRequestFactoryFactory.Netty;
 import org.springframework.vault.client.ClientHttpRequestFactoryFactory.OkHttp3;
 import org.springframework.vault.support.ClientOptions;
+import org.springframework.vault.support.SslConfiguration;
 import org.springframework.vault.util.Settings;
 import org.springframework.web.client.HttpStatusCodeException;
 import org.springframework.web.client.RestTemplate;
@@ -74,6 +76,14 @@ void nettyClientShouldWork() throws Exception {
 		((DisposableBean) factory).destroy();
 	}
 
+	@Test
+	void nettyClientWithoutSslConfigShouldWork() throws Exception {
+
+		ClientHttpRequestFactory factory = Netty.usingNetty(new ClientOptions(), SslConfiguration.unconfigured());
+
+		assertThat(ReflectionTestUtils.getField(factory, "sslContext")).isNotNull();
+	}
+
 	@Test
 	void okHttp3ClientShouldWork() throws Exception {