Skip to content

Commit 6746875

Browse files
committed
Polishing
De-duplicate image names
1 parent 6232497 commit 6746875

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

Jenkinsfile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ pipeline {
3232

3333
steps {
3434
script {
35-
def image = docker.build("springci/spring-vault-openjdk17-vault:${p['java.main.tag']}-${p['docker.vault.version']}", "--build-arg BASE=${p['docker.java.main.image']} --build-arg VAULT=${p['docker.vault.version']} -f ci/openjdk17-vault/Dockerfile .")
35+
def image = docker.build("${p['docker.image']}", "--build-arg BASE=${p['docker.java.main.image']} --build-arg VAULT=${p['docker.vault.version']} -f ci/openjdk17-vault/Dockerfile .")
3636
docker.withRegistry(p['docker.registry'], p['docker.credentials']) {
3737
image.push()
3838
}
@@ -59,7 +59,7 @@ pipeline {
5959
}
6060
steps {
6161
script {
62-
docker.image("harbor-repo.vmware.com/dockerhub-proxy-cache/springci/spring-vault-openjdk17-vault:${p['java.main.tag']}-${p['docker.vault.version']}").inside(p['docker.java.inside.basic']) {
62+
docker.image("${p['docker.image']}").inside(p['docker.java.inside.basic']) {
6363
sh 'src/test/bash/create_certificates.sh'
6464
sh '/opt/vault/vault server -config=$(pwd)/src/test/bash/vault.conf &'
6565
sh 'MAVEN_OPTS="-Duser.name=jenkins -Duser.home=/tmp/jenkins-home" ./mvnw -s settings.xml clean dependency:list verify -Dsort -U -B'
@@ -78,7 +78,7 @@ pipeline {
7878
}
7979
agent {
8080
docker {
81-
image "harbor-repo.vmware.com/dockerhub-proxy-cache/springci/spring-vault-openjdk17-vault:${p['java.main.tag']}-${p['docker.vault.version']}"
81+
image "${p['docker.image']}"
8282
args "${p['docker.java.inside.basic']}"
8383
}
8484
}

ci/pipeline.properties

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@ java.main.tag=17.0.3_7-jdk
44
# Docker container images - standard
55
docker.java.main.image=harbor-repo.vmware.com/dockerhub-proxy-cache/library/eclipse-temurin:${java.main.tag}
66

7+
# Main docker image name using during the CI build
8+
docker.image=harbor-repo.vmware.com/dockerhub-proxy-cache/springci/spring-vault-openjdk17-vault:${java.main.tag}-${'docker.vault.version'}
9+
710
# Supported versions of MongoDB
811
docker.vault.version=1.11.1
912

0 commit comments

Comments
 (0)