Refine VaultResponseSupport metadata copying.

Replace static copy method with an instance method.

Closes gh-823

Author: mp911de

spring-vault-core/src/main/java/org/springframework/vault/core/ReactiveVaultKeyValue1Template.java

@@ -60,9 +60,11 @@ public Flux<String> list(String path) {
 	public Mono<VaultResponse> get(String path) {
 
 		return doRead(path, Map.class, (response, map) -> {
+
 			VaultResponse vaultResponse = new VaultResponse();
-			VaultResponseSupport.updateWithoutData(vaultResponse, response);
+			vaultResponse.applyMetadata(response);
 			vaultResponse.setData(map);
+
 			return vaultResponse;
 		});
 	}

spring-vault-core/src/main/java/org/springframework/vault/core/ReactiveVaultKeyValue2Template.java

@@ -56,7 +56,7 @@ public Mono<VaultResponse> get(String path) {
 		return doRead(path, Map.class, (response, data) -> {
 
 			VaultResponse vaultResponse = new VaultResponse();
-			VaultResponse.updateWithoutData(vaultResponse, response);
+			vaultResponse.applyMetadata(response);
 			vaultResponse.setData(data);
 
 			return vaultResponse;

spring-vault-core/src/main/java/org/springframework/vault/core/VaultKeyValue1Template.java

@@ -31,8 +31,8 @@
  *
  * @author Mark Paluch
  * @author Younghwan Jang
- * @since 2.1
  * @see KeyValueBackend#KV_1
+ * @since 2.1
  */
 class VaultKeyValue1Template extends VaultKeyValueAccessor implements VaultKeyValueOperations {
 
@@ -67,8 +67,9 @@ public VaultResponse get(String path) {
 		Assert.hasText(path, "Path must not be empty");
 
 		return doRead(path, Map.class, (response, data) -> {
+
 			VaultResponse vaultResponse = new VaultResponse();
-			VaultResponse.updateWithoutData(vaultResponse, response);
+			vaultResponse.applyMetadata(response);
 			vaultResponse.setData(data);
 
 			return vaultResponse;

spring-vault-core/src/main/java/org/springframework/vault/core/VaultKeyValue2Template.java

@@ -56,7 +56,7 @@ public VaultResponse get(String path) {
 		return doRead(path, Map.class, (response, data) -> {
 
 			VaultResponse vaultResponse = new VaultResponse();
-			VaultResponse.updateWithoutData(vaultResponse, response);
+			vaultResponse.applyMetadata(response);
 			vaultResponse.setData(data);
 
 			return vaultResponse;

spring-vault-core/src/main/java/org/springframework/vault/support/VaultResponseSupport.java

@@ -63,15 +63,21 @@ public class VaultResponseSupport<T> {
 	@Nullable
 	private List<String> warnings;
 
-	public static void updateWithoutData(final VaultResponseSupport<?> dst, final VaultResponseSupport<?> src) {
-		dst.auth = src.auth;
-		dst.metadata = src.metadata;
-		dst.wrapInfo = src.wrapInfo;
-		dst.leaseDuration = src.leaseDuration;
-		dst.leaseId = src.leaseId;
-		dst.requestId = src.requestId;
-		dst.renewable = src.renewable;
-		dst.warnings = src.warnings;
+	/**
+	 * Apply metadata such as auth or warnings without copying data.
+	 * @param other
+	 * @since 3.1
+	 */
+	public void applyMetadata(VaultResponseSupport<?> other) {
+
+		this.auth = other.auth;
+		this.metadata = other.metadata;
+		this.wrapInfo = other.wrapInfo;
+		this.leaseDuration = other.leaseDuration;
+		this.leaseId = other.leaseId;
+		this.requestId = other.requestId;
+		this.renewable = other.renewable;
+		this.warnings = other.warnings;
 	}
 
 	/**