Mark private classes final

See gh-1479

Author: snicoll

spring-ws-core/src/main/java/org/springframework/ws/client/core/WebServiceTemplate.java

@@ -852,7 +852,8 @@ protected Object handleFault(WebServiceConnection connection, MessageContext mes
 	 * Adapter to enable use of a WebServiceMessageCallback inside a
 	 * WebServiceMessageExtractor.
 	 */
-	private static class WebServiceMessageCallbackMessageExtractor implements WebServiceMessageExtractor<Boolean> {
+	private static final class WebServiceMessageCallbackMessageExtractor
+			implements WebServiceMessageExtractor<Boolean> {
 
 		private final WebServiceMessageCallback callback;
 
@@ -869,7 +870,7 @@ public Boolean extractData(WebServiceMessage message) throws IOException, Transf
 	}
 
 	/** Adapter to enable use of a SourceExtractor inside a WebServiceMessageExtractor. */
-	private static class SourceExtractorMessageExtractor<T> implements WebServiceMessageExtractor<T> {
+	private static final class SourceExtractorMessageExtractor<T> implements WebServiceMessageExtractor<T> {
 
 		private final SourceExtractor<T> sourceExtractor;
 

spring-ws-core/src/main/java/org/springframework/ws/config/annotation/DelegatingWsConfiguration.java

@@ -69,7 +69,7 @@ protected void addReturnValueHandlers(List<MethodReturnValueHandler> returnValue
 		this.configurers.addReturnValueHandlers(returnValueHandlers);
 	}
 
-	private static class WsConfigurers implements WsConfigurer {
+	private static final class WsConfigurers implements WsConfigurer {
 
 		private final Supplier<Stream<WsConfigurer>> delegates;
 

spring-ws-core/src/main/java/org/springframework/ws/mime/AbstractMimeMessage.java

@@ -65,7 +65,7 @@ public final Attachment addAttachment(String contentId, InputStreamSource inputS
 	 * @author Arjen Poutsma
 	 * @since 1.0.0
 	 */
-	private static class InputStreamSourceDataSource implements DataSource {
+	private static final class InputStreamSourceDataSource implements DataSource {
 
 		private final InputStreamSource inputStreamSource;
 

spring-ws-core/src/main/java/org/springframework/ws/server/endpoint/AbstractStaxEventPayloadEndpoint.java

@@ -151,7 +151,7 @@ protected abstract void invokeInternal(XMLEventReader eventReader, XMLEventConsu
 	 * {@code WebServiceMessage} as soon as any method is called, thus lazily creating the
 	 * response.
 	 */
-	private class ResponseCreatingEventWriter implements XMLEventWriter {
+	private final class ResponseCreatingEventWriter implements XMLEventWriter {
 
 		private XMLEventWriter eventWriter;
 

spring-ws-core/src/main/java/org/springframework/ws/server/endpoint/AbstractStaxStreamPayloadEndpoint.java

@@ -126,7 +126,7 @@ private XMLStreamWriter getStreamWriter(Result result) {
 	 * {@code WebServiceMessage} as soon as any method is called, thus lazily creating the
 	 * response.
 	 */
-	private class ResponseCreatingStreamWriter implements XMLStreamWriter {
+	private final class ResponseCreatingStreamWriter implements XMLStreamWriter {
 
 		private MessageContext messageContext;
 

spring-ws-core/src/main/java/org/springframework/ws/server/endpoint/AbstractXomPayloadEndpoint.java

@@ -116,7 +116,7 @@ protected Serializer createSerializer(OutputStream outputStream) {
 	 */
 	protected abstract Element invokeInternal(Element requestElement) throws Exception;
 
-	private static class XomSourceCallback implements TraxUtils.SourceCallback {
+	private static final class XomSourceCallback implements TraxUtils.SourceCallback {
 
 		private Element element;
 
@@ -206,15 +206,15 @@ public void source(String systemId) throws Exception {
 	}
 
 	@SuppressWarnings("serial")
-	private static class XomParsingException extends NestedRuntimeException {
+	private static final class XomParsingException extends NestedRuntimeException {
 
 		private XomParsingException(ParsingException ex) {
 			super(ex.getMessage(), ex);
 		}
 
 	}
 
-	private static class StaxStreamConverter {
+	private static final class StaxStreamConverter {
 
 		private static Document convert(XMLStreamReader streamReader) throws XMLStreamException {
 			NodeFactory nodeFactory = new NodeFactory();

spring-ws-core/src/main/java/org/springframework/ws/server/endpoint/adapter/method/SourcePayloadMethodProcessor.java

@@ -129,7 +129,7 @@ protected XMLInputFactory createXmlInputFactory() {
 	}
 
 	/** Inner class to avoid a static JAXP 1.4 dependency. */
-	private static class Jaxp14StaxHandler {
+	private static final class Jaxp14StaxHandler {
 
 		private static boolean isStaxSource(Class<?> clazz) {
 			return StAXSource.class.isAssignableFrom(clazz);
@@ -141,7 +141,7 @@ private static Source createStaxSource(XMLStreamReader streamReader, String syst
 
 	}
 
-	private static class SystemIdStreamReaderDelegate extends StreamReaderDelegate {
+	private static final class SystemIdStreamReaderDelegate extends StreamReaderDelegate {
 
 		private final String systemId;
 

spring-ws-core/src/main/java/org/springframework/ws/server/endpoint/adapter/method/jaxb/AbstractJaxb2PayloadMethodProcessor.java

@@ -233,7 +233,7 @@ private JAXBContext getJaxbContext(Class<?> clazz) throws JAXBException {
 
 	// Callbacks
 
-	private class Jaxb2SourceCallback implements TraxUtils.SourceCallback {
+	private final class Jaxb2SourceCallback implements TraxUtils.SourceCallback {
 
 		private final Unmarshaller unmarshaller;
 
@@ -301,7 +301,7 @@ public void source(String systemId) throws Exception {
 
 	}
 
-	private class JaxbElementSourceCallback<T> implements TraxUtils.SourceCallback {
+	private final class JaxbElementSourceCallback<T> implements TraxUtils.SourceCallback {
 
 		private final Unmarshaller unmarshaller;
 
@@ -351,7 +351,7 @@ public void source(String systemId) throws Exception {
 
 	}
 
-	private class Jaxb2ResultCallback implements TraxUtils.ResultCallback {
+	private final class Jaxb2ResultCallback implements TraxUtils.ResultCallback {
 
 		private final Marshaller marshaller;
 
@@ -399,7 +399,7 @@ public void result(String systemId) throws Exception {
 
 	}
 
-	private class JaxbStreamingPayload implements StreamingPayload {
+	private final class JaxbStreamingPayload implements StreamingPayload {
 
 		private final Object jaxbElement;
 

spring-ws-core/src/main/java/org/springframework/ws/server/endpoint/support/PayloadRootUtils.java

@@ -89,7 +89,7 @@ public static QName getPayloadRootQName(Source source, TransformerHelper transfo
 		}
 	}
 
-	private static class PayloadRootSourceCallback implements TraxUtils.SourceCallback {
+	private static final class PayloadRootSourceCallback implements TraxUtils.SourceCallback {
 
 		private QName result;
 

spring-ws-core/src/main/java/org/springframework/ws/soap/saaj/SaajSoapFaultDetail.java

@@ -71,7 +71,7 @@ protected Detail getSaajDetail() {
 		return (Detail) getSaajElement();
 	}
 
-	private static class SaajSoapFaultDetailElementIterator implements Iterator<SoapFaultDetailElement> {
+	private static final class SaajSoapFaultDetailElementIterator implements Iterator<SoapFaultDetailElement> {
 
 		private final Iterator<DetailEntry> iterator;