SWS-1018 - Move creation of an empty SOAP 1.1 envelope to the factory.

To avoid SaajSoapMessage being created with an empty envelope, move the envelope creation process to SaajSoapMessageFactory.

Author: jaminh

spring-ws-core/src/main/java/org/springframework/ws/soap/saaj/SaajSoapMessage.java

@@ -57,6 +57,7 @@
  * wraps a {@link SOAPMessage}.
  *
  * @author Arjen Poutsma
+ * @author Greg Turnquist
  * @see SOAPMessage
  * @since 1.0.0
  */
@@ -115,12 +116,6 @@ public SaajSoapMessage(SOAPMessage soapMessage, boolean langAttributeOnSoap11Fau
 		saajMessage = soapMessage;
 		this.langAttributeOnSoap11FaultString = langAttributeOnSoap11FaultString;
 		this.messageFactory = messageFactory;
-		if (SoapVersion.SOAP_11.equals(getVersion())) {
-			MimeHeaders headers = soapMessage.getMimeHeaders();
-			if (ObjectUtils.isEmpty(headers.getHeader(TransportConstants.HEADER_SOAP_ACTION))) {
-				headers.addHeader(TransportConstants.HEADER_SOAP_ACTION, "\"\"");
-			}
-		}
 	}
 
 	/** Return the SAAJ {@code SOAPMessage} that this {@code SaajSoapMessage} is based on. */

spring-ws-core/src/main/java/org/springframework/ws/soap/saaj/SaajSoapMessageFactory.java

@@ -35,6 +35,7 @@
 
 import org.springframework.beans.factory.InitializingBean;
 import org.springframework.util.CollectionUtils;
+import org.springframework.util.ObjectUtils;
 import org.springframework.util.StringUtils;
 import org.springframework.ws.InvalidXmlException;
 import org.springframework.ws.soap.SoapMessageCreationException;
@@ -54,6 +55,7 @@
  * factory is injected, the {@link #setSoapVersion(org.springframework.ws.soap.SoapVersion)} property is ignored.
  *
  * @author Arjen Poutsma
+ * @author Greg Turnquist
  * @see org.springframework.ws.soap.saaj.SaajSoapMessage
  * @since 1.0.0
  */
@@ -290,6 +292,13 @@ protected void postProcess(SOAPMessage soapMessage) throws SOAPException {
 				soapMessage.setProperty(entry.getKey(), entry.getValue());
 			}
 		}
+
+		if (SOAPConstants.SOAP_1_1_PROTOCOL.equals(this.messageFactoryProtocol)) {
+			MimeHeaders headers = soapMessage.getMimeHeaders();
+			if (ObjectUtils.isEmpty(headers.getHeader(TransportConstants.HEADER_SOAP_ACTION))) {
+				headers.addHeader(TransportConstants.HEADER_SOAP_ACTION, "\"\"");
+			}
+		}
 	}
 
 	public String toString() {