Review checkstyle rules of spring-ws-core

See gh-1479

Author: snicoll

spring-ws-core/src/main/java/org/springframework/ws/client/core/SourceExtractor.java

@@ -34,6 +34,7 @@
  * Implementations of this interface perform the actual work of extracting results, but
  * don't need to worry about exception handling, or resource handling.
  *
+ * @param <T> the type of the source
  * @author Arjen Poutsma
  * @since 1.0.0
  * @see org.springframework.ws.client.core.WebServiceTemplate

spring-ws-core/src/main/java/org/springframework/ws/client/core/WebServiceMessageExtractor.java

@@ -35,6 +35,7 @@
  * Implementations of this interface perform the actual work of extracting results, but
  * don't need to worry about exception handling, or resource handling.
  *
+ * @param <T> the type of the result object
  * @author Arjen Poutsma
  * @since 1.0.0
  */

spring-ws-core/src/main/java/org/springframework/ws/client/core/WebServiceTemplate.java

@@ -208,7 +208,7 @@ public WebServiceTemplate(Marshaller marshaller, Unmarshaller unmarshaller) {
 	public String getDefaultUri() {
 		if (this.destinationProvider != null) {
 			URI uri = this.destinationProvider.getDestination();
-			return uri != null ? uri.toString() : null;
+			return (uri != null) ? uri.toString() : null;
 		}
 		else {
 			return null;
@@ -813,7 +813,7 @@ private void triggerHandleFault(int interceptorIndex, MessageContext messageCont
 	 * returned {@code false}.
 	 * @param interceptorIndex index of last interceptor that successfully completed
 	 * @param messageContext the message context
-	 * @param ex Exception thrown on handler execution, or {@code null} if none
+	 * @param ex exception thrown on handler execution, or {@code null} if none
 	 * @see ClientInterceptor#afterCompletion
 	 */
 	private void triggerAfterCompletion(int interceptorIndex, MessageContext messageContext, Exception ex)

spring-ws-core/src/main/java/org/springframework/ws/client/support/WebServiceAccessor.java

@@ -113,7 +113,7 @@ protected WebServiceConnection createConnection(URI uri) throws IOException {
 					try {
 						this.logger.debug("Opening [" + connection + "] to [" + connection.getUri() + "]");
 					}
-					catch (URISyntaxException e) {
+					catch (URISyntaxException ex) {
 						// ignore
 					}
 				}

spring-ws-core/src/main/java/org/springframework/ws/client/support/destination/Wsdl11DestinationProvider.java

@@ -130,7 +130,7 @@ protected URI lookupDestination() {
 			if (this.logger.isDebugEnabled()) {
 				this.logger.debug("Found location [" + location + "] in " + this.wsdlResource);
 			}
-			return location != null ? URI.create(location) : null;
+			return (location != null) ? URI.create(location) : null;
 		}
 		catch (IOException ex) {
 			throw new WebServiceIOException("Error extracting location from WSDL [" + this.wsdlResource + "]", ex);

spring-ws-core/src/main/java/org/springframework/ws/client/support/interceptor/AbstractValidatingInterceptor.java

@@ -184,8 +184,8 @@ public boolean handleRequest(MessageContext messageContext) throws WebServiceCli
 				try {
 					errors = this.validator.validate(requestSource);
 				}
-				catch (IOException e) {
-					throw new WebServiceIOException("Could not validate response: " + e.getMessage(), e);
+				catch (IOException ex) {
+					throw new WebServiceIOException("Could not validate response: " + ex.getMessage(), ex);
 				}
 				if (!ObjectUtils.isEmpty(errors)) {
 					return handleRequestValidationErrors(messageContext, errors);
@@ -234,8 +234,8 @@ public boolean handleResponse(MessageContext messageContext) throws WebServiceCl
 				try {
 					errors = this.validator.validate(responseSource);
 				}
-				catch (IOException e) {
-					throw new WebServiceIOException("Could not validate response: " + e.getMessage(), e);
+				catch (IOException ex) {
+					throw new WebServiceIOException("Could not validate response: " + ex.getMessage(), ex);
 				}
 				if (!ObjectUtils.isEmpty(errors)) {
 					return handleResponseValidationErrors(messageContext, errors);

spring-ws-core/src/main/java/org/springframework/ws/client/support/interceptor/ClientInterceptorAdapter.java

@@ -32,7 +32,7 @@
 public abstract class ClientInterceptorAdapter implements ClientInterceptor {
 
 	/**
-	 * Logger available to subclasses
+	 * Logger available to subclasses.
 	 */
 	protected final Log logger = LogFactory.getLog(getClass());
 

spring-ws-core/src/main/java/org/springframework/ws/client/support/interceptor/WebServiceValidationException.java

@@ -30,7 +30,7 @@
 @SuppressWarnings("serial")
 public class WebServiceValidationException extends WebServiceClientException {
 
-	private SAXParseException[] validationErrors;
+	private final SAXParseException[] validationErrors;
 
 	/**
 	 * Create a new instance of the {@code WebServiceValidationException} class.

spring-ws-core/src/main/java/org/springframework/ws/config/annotation/package-info.java

@@ -17,4 +17,4 @@
 /**
  * Annotations and supporting classes for declarative configuration.
  */
-package org.springframework.ws.config.annotation;
+package org.springframework.ws.config.annotation;

spring-ws-core/src/main/java/org/springframework/ws/context/MessageContext.java

@@ -65,7 +65,6 @@ public interface MessageContext {
 
 	/**
 	 * Removes the response message, if any.
-	 *
 	 * @since 1.5.0
 	 */
 	void clearResponse();