Fix Javadoc errors

See gh-1467

Author: snicoll

pom.xml

@@ -36,7 +36,6 @@
 
 	<properties>
 		<java.version>17</java.version>
-		<maven.javadoc.failOnError>false</maven.javadoc.failOnError>
 		<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
 		<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
 		<spring-asciidoctor-backends.version>0.0.5</spring-asciidoctor-backends.version>
@@ -827,7 +826,7 @@
 						<artifactId>maven-javadoc-plugin</artifactId>
 						<version>2.10.4</version>
 						<configuration>
-							<additionalparam>-Xdoclint:none</additionalparam>
+							<additionalparam>-Xdoclint:-missing</additionalparam>
 							<additionalparam>-quiet</additionalparam>
 						</configuration>
 						<executions>

spring-ws-core/src/main/java/org/springframework/ws/client/core/WebServiceTemplate.java

@@ -94,14 +94,14 @@
  * <li>Call {@link #hasError(WebServiceConnection,WebServiceMessage) hasError()} to check
  * if the connection has an error. For an HTTP transport, a status code other than
  * {@code 2xx} indicates an error. However, since a status code of 500 can also indicate a
- * SOAP fault, the template verifies whether the error is not a fault.</li>
+ * SOAP fault, the template verifies whether the error is not a fault.
  * <ul>
  * <li>If the connection has an error, call the {@link #handleError handleError()} method,
  * which by default throws a {@link WebServiceTransportException}.</li>
  * <li>If the connection has no error, continue with the next step.</li>
  * </ul>
  * <li>Invoke {@link WebServiceConnection#receive(WebServiceMessageFactory) receive} on
- * the connection to read the response message, if any.</li>
+ * the connection to read the response message, if any.
  * <ul>
  * <li>If no response was received, return {@code null} or {@code false}</li>
  * <li>Call {@link #hasFault(WebServiceConnection,WebServiceMessage) hasFault()} to

spring-ws-core/src/main/java/org/springframework/ws/client/core/support/WebServiceGatewaySupport.java

@@ -41,7 +41,7 @@
  * template are to be used.
  * <p>
  * Note that when {@link #setWebServiceTemplate(WebServiceTemplate) injecting a
- * {@code WebServiceTemplate}} directly, the convenience setters
+ * WebServiceTemplate directly}, the convenience setters
  * ({@link #setMarshaller(Marshaller)}, {@link #setUnmarshaller(Unmarshaller)},
  * {@link #setMessageSender(WebServiceMessageSender)},
  * {@link #setMessageSenders(WebServiceMessageSender[])}, and

spring-ws-core/src/main/java/org/springframework/ws/client/support/destination/Wsdl11DestinationProvider.java

@@ -91,6 +91,7 @@ public void setWsdl(Resource wsdlResource) {
 	 * <p>
 	 * The expression can use the following bound prefixes: <blockquote>
 	 * <table>
+	 * <caption>Bound Prefixes</caption>
 	 * <tr>
 	 * <th>Prefix</th>
 	 * <th>Namespace</th>

spring-ws-core/src/main/java/org/springframework/ws/config/MarshallingEndpointsBeanDefinitionParser.java

@@ -25,7 +25,7 @@
 import org.springframework.util.StringUtils;
 
 /**
- * Parser for the <code>&lt;sws:marshalling-endpoints/&gt; element.
+ * Parser for the {@code <sws:marshalling-endpoints/>} element.
  *
  * @author Arjen Poutsma
  * @since 1.5.0

spring-ws-core/src/main/java/org/springframework/ws/config/XPathEndpointsBeanDefinitionParser.java

@@ -27,7 +27,7 @@
 import org.springframework.util.xml.DomUtils;
 
 /**
- * Parser for the <code>&lt;sws:xpath-endpoints/&gt; element.
+ * Parser for the {@code <sws:xpath-endpoints>} element.
  *
  * @author Arjen Poutsma
  * @since 1.5.0

spring-ws-core/src/main/java/org/springframework/ws/config/annotation/EnableWs.java

@@ -30,20 +30,19 @@
  * Web Services configuration defined in {@link WsConfigurationSupport} imported. For
  * instance:
  *
- * <pre class="code">
+ * <pre><code class='java'>
  * &#064;Configuration
  * &#064;EnableWs
  * &#064;ComponentScan(basePackageClasses = { MyConfiguration.class })
  * public class MyWsConfiguration {
  *
- * }
- * </pre>
+ * }</code></pre>
  * <p>
  * Customize the imported configuration by implementing the {@link WsConfigurer} interface
  * or more likely by extending the {@link WsConfigurerAdapter} base class and overriding
  * individual methods:
  *
- * <pre class="code">
+ * <pre><code class='java'>
  * &#064;Configuration
  * &#064;EnableWs
  * &#064;ComponentScan(basePackageClasses = { MyConfiguration.class })
@@ -60,14 +59,13 @@
  * 	}
  *
  * 	// More overridden methods ...
- * }
- * </pre>
+ * }</code></pre>
  * <p>
  * If the customization options of {@link WsConfigurer} do not expose something you need
  * to configure, consider removing the {@code @EnableWs} annotation and extending directly
  * from {@link WsConfigurationSupport} overriding selected {@code @Bean} methods:
  *
- * <pre class="code">
+ * <pre><code class='java'>
  * &#064;Configuration
  * &#064;ComponentScan(basePackageClasses = { MyConfiguration.class })
  * public class MyConfiguration extends WsConfigurationSupport {
@@ -83,8 +81,7 @@
  * 		// Create or delegate to "super" to create and
  * 		// customize properties of DefaultMethodEndpointAdapter
  * 	}
- * }
- * </pre>
+ * }</code></pre>
  *
  * @see WsConfigurer
  * @see WsConfigurerAdapter

spring-ws-core/src/main/java/org/springframework/ws/server/endpoint/adapter/MarshallingMethodEndpointAdapter.java

@@ -33,15 +33,10 @@
  * Adapter that supports endpoint methods that use marshalling. Supports methods with the
  * following signature:
  *
- * <pre>
- * void handleMyMessage(MyUnmarshalledType request);
- * </pre>
- *
- * or
- *
- * <pre>
- * MyMarshalledType handleMyMessage(MyUnmarshalledType request);
- * </pre>
+ * <pre><code class='java'>
+ * void handleMyMessage(MyUnmarshalledType request);</code></pre> or
+ * <pre><code class='java'>
+ * MyMarshalledType handleMyMessage(MyUnmarshalledType request);</code></pre>
  *
  * I.e. methods that take a single parameter that {@link Unmarshaller#supports(Class) is
  * supported} by the {@link Unmarshaller}, and return either {@code void} or a type

spring-ws-core/src/main/java/org/springframework/ws/server/endpoint/adapter/MessageMethodEndpointAdapter.java

@@ -27,9 +27,8 @@
  * Adapter that supports endpoint methods with message contexts. Supports methods with the
  * following signature:
  *
- * <pre>
- * void handleMyMessage(MessageContext request);
- * </pre>
+ * <pre><code class='java'>
+ * void handleMyMessage(MessageContext request);</code></pre>
  *
  * I.e. methods that take a single {@link MessageContext} parameter, and return
  * {@code void}. The method can have any name, as long as it is mapped by an

spring-ws-core/src/main/java/org/springframework/ws/server/endpoint/adapter/PayloadMethodEndpointAdapter.java

@@ -28,21 +28,12 @@
 
 /**
  * Adapter that supports endpoint methods that use marshalling. Supports methods with the
- * following signature:
- *
- * <pre>
- * void handleMyMessage(Source request);
- * </pre>
- *
- * or
- *
- * <pre>
- * Source handleMyMessage(Source request);
- * </pre>
- *
- * I.e. methods that take a single {@link Source} parameter, and return either
- * {@code void} or a {@link Source}. The method can have any name, as long as it is mapped
- * by an {@link org.springframework.ws.server.EndpointMapping}.
+ * following signature: <pre><code class='java'>
+ * void handleMyMessage(Source request);</code></pre> or <pre><code class='java'>
+ * Source handleMyMessage(Source request);</code></pre> I.e. methods that take a single
+ * {@link Source} parameter, and return either {@code void} or a {@link Source}. The
+ * method can have any name, as long as it is mapped by an
+ * {@link org.springframework.ws.server.EndpointMapping}.
  * <p>
  * This adapter is registered by default by the {@link MessageDispatcher} and
  * {@link SoapMessageDispatcher}.