Skip to content

Commit 5a1e502

Browse files
committed
Adapt to deprecation
1 parent fb4ab82 commit 5a1e502

File tree

38 files changed

+103
-50
lines changed

38 files changed

+103
-50
lines changed

spring-ws-core/src/main/java/org/springframework/ws/server/endpoint/annotation/XPathParam.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
* </ul>
3636
*
3737
* @author Arjen Poutsma
38-
* @see org.springframework.ws.server.endpoint.adapter.XPathParamAnnotationMethodEndpointAdapter
38+
* @see org.springframework.ws.server.endpoint.adapter.method.XPathParamMethodArgumentResolver
3939
* @since 1.0.0
4040
*/
4141
@Target(ElementType.PARAMETER)

spring-ws-core/src/main/java/org/springframework/ws/server/endpoint/interceptor/PayloadTransformingInterceptor.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import java.io.ByteArrayInputStream;
2020
import java.io.ByteArrayOutputStream;
2121

22+
import javax.xml.parsers.SAXParserFactory;
2223
import javax.xml.transform.Source;
2324
import javax.xml.transform.Templates;
2425
import javax.xml.transform.Transformer;
@@ -30,7 +31,6 @@
3031
import org.apache.commons.logging.Log;
3132
import org.apache.commons.logging.LogFactory;
3233
import org.xml.sax.XMLReader;
33-
import org.xml.sax.helpers.XMLReaderFactory;
3434

3535
import org.springframework.beans.factory.InitializingBean;
3636
import org.springframework.core.io.Resource;
@@ -139,7 +139,9 @@ public void afterPropertiesSet() throws Exception {
139139
throw new IllegalArgumentException("Setting either 'requestXslt' or 'responseXslt' is required");
140140
}
141141
TransformerFactory transformerFactory = getTransformerFactory();
142-
XMLReader xmlReader = XMLReaderFactory.createXMLReader();
142+
SAXParserFactory parserFactory = SAXParserFactory.newInstance();
143+
parserFactory.setNamespaceAware(true);
144+
XMLReader xmlReader = parserFactory.newSAXParser().getXMLReader();
143145
xmlReader.setFeature("http://xml.org/sax/features/namespace-prefixes", true);
144146
if (requestXslt != null) {
145147
Assert.isTrue(requestXslt.exists(), "requestXslt \"" + requestXslt + "\" does not exit");

spring-ws-core/src/main/java/org/springframework/ws/server/endpoint/mapping/jaxb/XmlRootElementEndpointMapping.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
package org.springframework.ws.server.endpoint.mapping.jaxb;
1818

19+
import java.lang.reflect.InvocationTargetException;
1920
import java.lang.reflect.Method;
2021

2122
import javax.xml.namespace.QName;
@@ -86,13 +87,13 @@ protected QName getLookupKeyForMethod(Method method) {
8687

8788
private QName handleRootElement(Class<?> parameterType) {
8889
try {
89-
Object param = parameterType.newInstance();
90+
Object param = parameterType.getDeclaredConstructor().newInstance();
9091
QName result = getElementName(parameterType, param);
9192
if (result != null) {
9293
return result;
9394
}
9495
}
95-
catch (InstantiationException | IllegalAccessException e) {
96+
catch (InvocationTargetException | NoSuchMethodException | InstantiationException | IllegalAccessException e) {
9697
// ignore
9798
}
9899
return null;

spring-ws-core/src/main/java/org/springframework/ws/transport/http/MessageDispatcherServlet.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -323,6 +323,7 @@ protected void onRefresh(ApplicationContext context) {
323323
}
324324

325325
@Override
326+
@SuppressWarnings("deprecation")
326327
protected long getLastModified(HttpServletRequest httpServletRequest) {
327328
WsdlDefinition definition = getWsdlDefinition(httpServletRequest);
328329
if (definition != null) {

spring-ws-core/src/main/java/org/springframework/ws/transport/http/WebServiceMessageReceiverHandlerAdapter.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ public class WebServiceMessageReceiverHandlerAdapter extends WebServiceMessageRe
4949
implements HandlerAdapter {
5050

5151
@Override
52+
@Deprecated
5253
public long getLastModified(HttpServletRequest request, Object handler) {
5354
return -1L;
5455
}

spring-ws-core/src/main/java/org/springframework/ws/transport/http/WsdlDefinitionHandlerAdapter.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,7 @@ public void setTransformSchemaLocations(boolean transformSchemaLocations) {
140140
}
141141

142142
@Override
143+
@Deprecated
143144
public long getLastModified(HttpServletRequest request, Object handler) {
144145
Source definitionSource = ((WsdlDefinition) handler).getSource();
145146
return LastModifiedHelper.getLastModified(definitionSource);

spring-ws-core/src/main/java/org/springframework/ws/transport/http/XsdSchemaHandlerAdapter.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,7 @@ public void setTransformSchemaLocations(boolean transformSchemaLocations) {
8888
}
8989

9090
@Override
91+
@Deprecated
9192
public long getLastModified(HttpServletRequest request, Object handler) {
9293
Source schemaSource = ((XsdSchema) handler).getSource();
9394
return LastModifiedHelper.getLastModified(schemaSource);

spring-ws-core/src/main/java/org/springframework/ws/wsdl/wsdl11/SimpleWsdl11Definition.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,12 @@
1818

1919
import java.io.IOException;
2020

21+
import javax.xml.parsers.ParserConfigurationException;
22+
import javax.xml.parsers.SAXParserFactory;
2123
import javax.xml.transform.Source;
2224

2325
import org.xml.sax.SAXException;
2426
import org.xml.sax.XMLReader;
25-
import org.xml.sax.helpers.XMLReaderFactory;
2627

2728
import org.springframework.beans.factory.InitializingBean;
2829
import org.springframework.core.io.Resource;
@@ -72,11 +73,13 @@ public void afterPropertiesSet() throws Exception {
7273
@Override
7374
public Source getSource() {
7475
try {
75-
XMLReader xmlReader = XMLReaderFactory.createXMLReader();
76+
SAXParserFactory parserFactory = SAXParserFactory.newInstance();
77+
parserFactory.setNamespaceAware(true);
78+
XMLReader xmlReader = parserFactory.newSAXParser().getXMLReader();
7679
xmlReader.setFeature("http://xml.org/sax/features/namespace-prefixes", true);
7780
return new ResourceSource(xmlReader, wsdlResource);
7881
}
79-
catch (SAXException ex) {
82+
catch (SAXException | ParserConfigurationException ex) {
8083
throw new WsdlDefinitionException("Could not create XMLReader", ex);
8184
}
8285
catch (IOException ex) {

spring-ws-core/src/test/java/org/springframework/ws/AbstractWebServiceMessageTest.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626

2727
import javax.xml.parsers.DocumentBuilder;
2828
import javax.xml.parsers.DocumentBuilderFactory;
29+
import javax.xml.parsers.SAXParserFactory;
2930
import javax.xml.stream.XMLEventReader;
3031
import javax.xml.stream.XMLEventWriter;
3132
import javax.xml.stream.XMLInputFactory;
@@ -48,7 +49,6 @@
4849
import org.xml.sax.InputSource;
4950
import org.xml.sax.XMLReader;
5051
import org.xml.sax.helpers.DefaultHandler;
51-
import org.xml.sax.helpers.XMLReaderFactory;
5252

5353
import org.springframework.core.io.ClassPathResource;
5454
import org.springframework.core.io.Resource;
@@ -187,8 +187,9 @@ public void testStreamReaderPayload() throws Exception {
187187
}
188188

189189
private void validateMessage() throws Exception {
190-
191-
XMLReader xmlReader = XMLReaderFactory.createXMLReader();
190+
SAXParserFactory parserFactory = SAXParserFactory.newInstance();
191+
parserFactory.setNamespaceAware(true);
192+
XMLReader xmlReader = parserFactory.newSAXParser().getXMLReader();
192193
xmlReader.setContentHandler(new DefaultHandler());
193194
ByteArrayOutputStream os = new ByteArrayOutputStream();
194195
webServiceMessage.writeTo(os);

spring-ws-core/src/test/java/org/springframework/ws/config/WebServiceNamespaceHandlerTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727

2828
import static org.assertj.core.api.Assertions.assertThat;
2929

30+
@Deprecated
3031
public class WebServiceNamespaceHandlerTest {
3132

3233
private ApplicationContext applicationContext;

0 commit comments

Comments
 (0)