SWS-469: Content type not set accouring to Http specification, RFC 2616

Author: poutsma

core/src/main/java/org/springframework/ws/soap/axiom/AxiomSoapMessage.java

@@ -221,7 +221,7 @@ public void writeTo(OutputStream outputStream) throws IOException {
                 TransportOutputStream transportOutputStream = (TransportOutputStream) outputStream;
                 String contentType = format.getContentType();
                 if (!hasAttachments) {
-                    contentType += "; charset=\"" + charsetEncoding + "\"";
+                    contentType += "; charset=" + charsetEncoding;
                 }
                 if (SoapVersion.SOAP_11 == getVersion()) {
                     transportOutputStream.addHeader(TransportConstants.HEADER_SOAP_ACTION, soapAction);

core/src/test/java/org/springframework/ws/soap/AbstractSoapMessageTestCase.java

@@ -16,13 +16,21 @@
 
 package org.springframework.ws.soap;
 
+import java.io.ByteArrayOutputStream;
+import java.util.Map;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+import org.xml.sax.SAXParseException;
+
 import org.springframework.core.io.Resource;
 import org.springframework.util.StringUtils;
 import org.springframework.ws.mime.AbstractMimeMessageTestCase;
 import org.springframework.ws.mime.MimeMessage;
+import org.springframework.ws.transport.MockTransportOutputStream;
+import org.springframework.ws.transport.TransportConstants;
 import org.springframework.xml.validation.XmlValidator;
 import org.springframework.xml.validation.XmlValidatorFactory;
-import org.xml.sax.SAXParseException;
 
 public abstract class AbstractSoapMessageTestCase extends AbstractMimeMessageTestCase {
 
@@ -50,6 +58,21 @@ public void testSoapAction() throws Exception {
         assertEquals("Invalid SOAP Action", "\"SoapAction\"", soapMessage.getSoapAction());
     }
 
+    public void testCharsetAttribute() throws Exception {
+        MockTransportOutputStream outputStream = new MockTransportOutputStream(new ByteArrayOutputStream());
+        soapMessage.writeTo(outputStream);
+        Map headers = outputStream.getHeaders();
+        String contentType = (String) headers.get(TransportConstants.HEADER_CONTENT_TYPE);
+        if (contentType != null) {
+            Pattern charsetPattern = Pattern.compile("charset\\s*=\\s*([^;]+)");
+            Matcher matcher = charsetPattern.matcher(contentType);
+            if (matcher.find() && matcher.groupCount() == 1) {
+                String charset = matcher.group(1).trim();
+                assertTrue("Invalid charset", charset.indexOf('"') < 0);
+            }
+        }
+    }
+
     protected abstract Resource[] getSoapSchemas();
 
     public abstract void testGetVersion() throws Exception;