OperationId generation problem. Fixes #1392

Author: bnasslahsen

springdoc-openapi-common/src/main/java/org/springdoc/core/OpenAPIService.java

@@ -38,8 +38,10 @@
 import java.util.stream.Collectors;
 import java.util.stream.Stream;
 
+import com.fasterxml.jackson.core.JsonProcessingException;
 import io.swagger.v3.core.jackson.TypeNameResolver;
 import io.swagger.v3.core.util.AnnotationsUtils;
+import io.swagger.v3.core.util.Json;
 import io.swagger.v3.oas.annotations.Hidden;
 import io.swagger.v3.oas.annotations.OpenAPIDefinition;
 import io.swagger.v3.oas.annotations.security.SecuritySchemes;
@@ -229,8 +231,15 @@ public void build(Locale locale) {
 			this.calculatedOpenAPI.setComponents(new Components());
 			this.calculatedOpenAPI.setPaths(new Paths());
 		}
-		else
-			this.calculatedOpenAPI = openAPI;
+		else {
+			try {
+				this.calculatedOpenAPI = Json.mapper()
+						.readValue(Json.mapper().writeValueAsString(openAPI), OpenAPI.class);
+			}
+			catch (JsonProcessingException e) {
+				LOGGER.warn("Json Processing Exception occurred: {}", e.getMessage());
+			}
+		}
 
 		if (apiDef.isPresent()) {
 			buildOpenAPIWithOpenAPIDefinition(calculatedOpenAPI, apiDef.get(), locale);

springdoc-openapi-webmvc-core/src/test/java/test/org/springdoc/api/app173/HelloController.java

@@ -0,0 +1,13 @@
+package test.org.springdoc.api.app173;
+
+import org.springframework.web.bind.annotation.GetMapping;
+import org.springframework.web.bind.annotation.RestController;
+
+@RestController
+public class HelloController {
+
+    @GetMapping("/test")
+    public void printHello() {
+        System.out.println("Hello");
+    }
+}

springdoc-openapi-webmvc-core/src/test/java/test/org/springdoc/api/app173/SpringDocApp173Test.java

@@ -0,0 +1,69 @@
+/*
+ *
+ *  * Copyright 2019-2020 the original author or authors.
+ *  *
+ *  * Licensed under the Apache License, Version 2.0 (the "License");
+ *  * you may not use this file except in compliance with the License.
+ *  * You may obtain a copy of the License at
+ *  *
+ *  *      https://www.apache.org/licenses/LICENSE-2.0
+ *  *
+ *  * Unless required by applicable law or agreed to in writing, software
+ *  * distributed under the License is distributed on an "AS IS" BASIS,
+ *  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  * See the License for the specific language governing permissions and
+ *  * limitations under the License.
+ *
+ */
+
+package test.org.springdoc.api.app173;
+
+import java.util.Locale;
+
+import io.swagger.v3.oas.models.OpenAPI;
+import org.junit.jupiter.api.Test;
+import org.springdoc.core.Constants;
+import test.org.springdoc.api.AbstractSpringDocTest;
+
+import org.springframework.boot.autoconfigure.SpringBootApplication;
+import org.springframework.context.annotation.Bean;
+import org.springframework.http.HttpHeaders;
+import org.springframework.test.web.servlet.MvcResult;
+
+import static org.hamcrest.Matchers.is;
+import static org.skyscreamer.jsonassert.JSONAssert.assertEquals;
+import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get;
+import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.jsonPath;
+import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;
+
+public class SpringDocApp173Test extends AbstractSpringDocTest {
+
+	@SpringBootApplication
+	static class SpringDocTestApp {
+		@Bean
+		public OpenAPI openAPI() {
+			return new OpenAPI();
+		}
+	}
+
+	@Test
+	@Override
+	public void testApp() throws Exception {
+		Locale.setDefault(Locale.US);
+		testApp(Locale.US);
+		testApp(Locale.FRANCE);
+	}
+
+	private void testApp(Locale locale) throws Exception {
+		className = getClass().getSimpleName();
+		String testNumber = className.replaceAll("[^0-9]", "");
+		MvcResult mockMvcResult =
+				mockMvc.perform(get(Constants.DEFAULT_API_DOCS_URL).locale(locale).header(HttpHeaders.ACCEPT_LANGUAGE, locale.toLanguageTag())).andExpect(status().isOk())
+						.andExpect(jsonPath("$.openapi", is("3.0.1"))).andReturn();
+		String result = mockMvcResult.getResponse().getContentAsString();
+		String expected = getContent("results/app" + testNumber +".json");
+		assertEquals(expected, result, true);
+	}
+
+
+}

springdoc-openapi-webmvc-core/src/test/resources/results/app173.json

@@ -0,0 +1,29 @@
+{
+  "openapi": "3.0.1",
+  "info": {
+    "title": "OpenAPI definition",
+    "version": "v0"
+  },
+  "servers": [
+    {
+      "url": "http://localhost",
+      "description": "Generated server url"
+    }
+  ],
+  "paths": {
+    "/test": {
+      "get": {
+        "tags": [
+          "hello-controller"
+        ],
+        "operationId": "printHello",
+        "responses": {
+          "200": {
+            "description": "OK"
+          }
+        }
+      }
+    }
+  },
+  "components": {}
+}