Skip to content

Commit e7c10c4

Browse files
committed
remove unnecessary relative url configuration
1 parent a135b78 commit e7c10c4

File tree

10 files changed

+4
-105
lines changed

10 files changed

+4
-105
lines changed

springdoc-openapi-common/src/main/java/org/springdoc/api/AbstractOpenApiResource.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -304,13 +304,4 @@ protected static String decode(String requestURI) {
304304
return requestURI;
305305
}
306306
}
307-
308-
protected static String getRelativeUrl(String url){
309-
try {
310-
URI uri = new URI(url);
311-
return StringUtils.appendIfMissing(new URI(null, null, uri.getPath(), null).toString(), "/");
312-
} catch (URISyntaxException e) {
313-
return url;
314-
}
315-
}
316307
}

springdoc-openapi-common/src/main/java/org/springdoc/core/Constants.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@ public final class Constants {
1414
public static final String SPRINGDOC_SWAGGER_UI_ENABLED = "springdoc.swagger-ui.enabled";
1515
public static final String SPRINGDOC_SHOW_ACTUATOR = "springdoc.show-actuator";
1616
public static final String SPRINGDOC_SHOW_ACTUATOR_VALUE = "${" + SPRINGDOC_SHOW_ACTUATOR + ":false}";
17-
public static final String SPRINGDOC_RELATIVE_BASEURL = "springdoc.relative-baseurl";
18-
public static final String SPRINGDOC_RELATIVE_BASEURL_VALUE = "${" + SPRINGDOC_RELATIVE_BASEURL + ":false}";
1917
public static final String SPRINGDOC_PACKAGES_TO_SCAN = "${springdoc.packagesToScan:#{null}}";
2018
public static final String SPRINGDOC_PATHS_TO_MATCH = "${springdoc.pathsToMatch:#{null}}";
2119
public static final String SPRINGDOC_ACTUATOR_TAG = "Actuator";

springdoc-openapi-common/src/main/java/org/springdoc/core/SpringDocConfigProperties.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
public class SpringDocConfigProperties {
1515

1616
private Boolean showActuator = false;
17-
private Boolean relativeBaseurl = false;
1817
private Webjars webjars = new Webjars();
1918
private ApiDocs apiDocs = new ApiDocs();
2019
private List<String> packagesToScan;
@@ -36,14 +35,6 @@ public void setShowActuator(Boolean showActuator) {
3635
this.showActuator = showActuator;
3736
}
3837

39-
public Boolean getRelativeBaseurl() {
40-
return relativeBaseurl;
41-
}
42-
43-
public void setRelativeBaseurl(Boolean relativeBaseurl) {
44-
this.relativeBaseurl = relativeBaseurl;
45-
}
46-
4738
public Webjars getWebjars() {
4839
return webjars;
4940
}

springdoc-openapi-webflux-core/src/main/java/org/springdoc/api/OpenApiResource.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,6 @@
3232
@RestController
3333
public class OpenApiResource extends AbstractOpenApiResource {
3434

35-
@Value(SPRINGDOC_RELATIVE_BASEURL_VALUE)
36-
private boolean relativeBaseurl;
37-
3835
private final RequestMappingInfoHandlerMapping requestMappingHandlerMapping;
3936

4037
public OpenApiResource(OpenAPIBuilder openAPIBuilder, AbstractRequestBuilder requestBuilder,
@@ -87,7 +84,7 @@ protected void getPaths(Map<String, Object> restControllers) {
8784
private void calculateServerUrl(ServerHttpRequest serverHttpRequest, String apiDocsUrl) {
8885
String requestUrl = decode(serverHttpRequest.getURI().toString());
8986
String serverBaseUrl = requestUrl.substring(0, requestUrl.length() - apiDocsUrl.length());
90-
openAPIBuilder.setServerBaseUrl(relativeBaseurl ? getRelativeUrl(serverBaseUrl) : serverBaseUrl);
87+
openAPIBuilder.setServerBaseUrl(serverBaseUrl);
9188
}
9289

9390
}

springdoc-openapi-webmvc-core/src/main/java/org/springdoc/api/MultipleOpenApiResource.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,6 @@ public class MultipleOpenApiResource implements InitializingBean {
3636
@Value(SPRINGDOC_SHOW_ACTUATOR_VALUE)
3737
private boolean showActuator;
3838

39-
@Value(SPRINGDOC_RELATIVE_BASEURL_VALUE)
40-
private boolean protocolRelativBaseurl;
41-
4239
public MultipleOpenApiResource(List<GroupedOpenApi> groupedOpenApis,
4340
ObjectFactory<OpenAPIBuilder> defaultOpenAPIBuilder, AbstractRequestBuilder requestBuilder,
4441
AbstractResponseBuilder responseBuilder, OperationBuilder operationParser,
@@ -65,7 +62,7 @@ public void afterPropertiesSet() throws Exception {
6562
requestMappingHandlerMapping,
6663
servletContextProvider,
6764
Optional.of(item.getOpenApiCustomisers()), item.getPathsToMatch(), item.getPackagesToScan(),
68-
showActuator, protocolRelativBaseurl
65+
showActuator
6966
)
7067
));
7168
}

springdoc-openapi-webmvc-core/src/main/java/org/springdoc/api/OpenApiResource.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,6 @@ public class OpenApiResource extends AbstractOpenApiResource {
4141
@Value(SPRINGDOC_SHOW_ACTUATOR_VALUE)
4242
private boolean showActuator;
4343

44-
@Value(SPRINGDOC_RELATIVE_BASEURL_VALUE)
45-
private boolean relativBaseurl;
46-
4744
public OpenApiResource(OpenAPIBuilder openAPIBuilder, AbstractRequestBuilder requestBuilder,
4845
AbstractResponseBuilder responseBuilder, OperationBuilder operationParser,
4946
RequestMappingInfoHandlerMapping requestMappingHandlerMapping, Optional<ActuatorProvider> servletContextProvider,
@@ -57,12 +54,11 @@ public OpenApiResource(OpenAPIBuilder openAPIBuilder, AbstractRequestBuilder req
5754
AbstractResponseBuilder responseBuilder, OperationBuilder operationParser,
5855
RequestMappingInfoHandlerMapping requestMappingHandlerMapping, Optional<ActuatorProvider> servletContextProvider,
5956
Optional<List<OpenApiCustomiser>> openApiCustomisers, List<String> pathsToMatch, List<String> packagesToScan,
60-
boolean showActuator, boolean relativBaseurl) {
57+
boolean showActuator) {
6158
super(openAPIBuilder, requestBuilder, responseBuilder, operationParser, openApiCustomisers, pathsToMatch, packagesToScan);
6259
this.requestMappingHandlerMapping = requestMappingHandlerMapping;
6360
this.servletContextProvider = servletContextProvider;
6461
this.showActuator = showActuator;
65-
this.relativBaseurl = relativBaseurl;
6662
}
6763

6864

@@ -135,6 +131,6 @@ private boolean isRestController(Map<String, Object> restControllers, HandlerMet
135131
private void calculateServerUrl(HttpServletRequest request, String apiDocsUrl) {
136132
String requestUrl = decode(request.getRequestURL().toString());
137133
String calculatedUrl = requestUrl.substring(0, requestUrl.length() - apiDocsUrl.length());
138-
openAPIBuilder.setServerBaseUrl(relativBaseurl ? getRelativeUrl(calculatedUrl) : calculatedUrl);
134+
openAPIBuilder.setServerBaseUrl(calculatedUrl);
139135
}
140136
}

springdoc-openapi-webmvc-core/src/test/java/test/org/springdoc/api/app71/HelloController.java

Lines changed: 0 additions & 15 deletions
This file was deleted.

springdoc-openapi-webmvc-core/src/test/java/test/org/springdoc/api/app71/SpringDocApp71Test.java

Lines changed: 0 additions & 8 deletions
This file was deleted.

springdoc-openapi-webmvc-core/src/test/java/test/org/springdoc/api/app71/SpringDocTestApp.java

Lines changed: 0 additions & 11 deletions
This file was deleted.

springdoc-openapi-webmvc-core/src/test/resources/results/app71.json

Lines changed: 0 additions & 37 deletions
This file was deleted.

0 commit comments

Comments
 (0)