Skip to content

Commit ea45be8

Browse files
committed
Code review. Fixes #2625
1 parent 3b577e4 commit ea45be8

File tree

1 file changed

+17
-45
lines changed

1 file changed

+17
-45
lines changed

springdoc-openapi-tests/springdoc-openapi-hateoas-tests/src/test/java/test/org/springdoc/api/app10/SpringDocApp10NotSpecifiedTest.java

Lines changed: 17 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -22,38 +22,35 @@
2222

2323
package test.org.springdoc.api.app10;
2424

25-
import java.lang.reflect.Field;
26-
import java.util.HashMap;
27-
import java.util.Iterator;
28-
import java.util.Map;
29-
import java.util.Map.Entry;
25+
import java.util.Optional;
3026

31-
import com.fasterxml.jackson.databind.ObjectMapper;
32-
import com.fasterxml.jackson.databind.introspect.SimpleMixInResolver;
33-
import com.fasterxml.jackson.databind.type.ClassKey;
34-
import org.apache.commons.lang3.reflect.FieldUtils;
35-
import org.junit.jupiter.api.AfterEach;
36-
import org.junit.jupiter.api.BeforeEach;
27+
import io.swagger.v3.core.converter.ModelConverter;
28+
import io.swagger.v3.core.converter.ModelConverters;
29+
import org.junit.jupiter.api.BeforeAll;
3730
import org.junit.jupiter.api.Test;
38-
import org.springdoc.core.providers.ObjectMapperProvider;
31+
import org.springdoc.core.converters.PageOpenAPIConverter;
32+
import org.springdoc.core.converters.SchemaPropertyDeprecatingConverter;
3933
import org.springdoc.core.utils.Constants;
34+
import test.org.springdoc.api.AbstractSpringDocTest;
4035

41-
import org.springframework.beans.factory.annotation.Autowired;
42-
import org.springframework.boot.SpringBootConfiguration;
4336
import org.springframework.boot.autoconfigure.SpringBootApplication;
44-
import org.springframework.data.web.config.EnableSpringDataWebSupport;
45-
import test.org.springdoc.api.AbstractSpringDocTest;
4637

4738
import static org.hamcrest.Matchers.is;
4839
import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get;
49-
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.*;
40+
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.content;
41+
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.jsonPath;
42+
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;
5043

5144
public class SpringDocApp10NotSpecifiedTest extends AbstractSpringDocTest {
5245

53-
private final Map<ClassKey, Class<?>> springMixins = new HashMap<>();
5446

55-
@Autowired
56-
ObjectMapperProvider objectMapperProvider;
47+
@BeforeAll
48+
public static void init() {
49+
Optional<ModelConverter> pageOpenAPIConverter =
50+
ModelConverters.getInstance().getConverters()
51+
.stream().filter(modelConverter -> modelConverter instanceof PageOpenAPIConverter).findAny();
52+
pageOpenAPIConverter.ifPresent(ModelConverters.getInstance()::removeConverter);
53+
}
5754

5855
@Override
5956
@Test
@@ -69,29 +66,4 @@ public static class SpringDocTestApp {
6966

7067
}
7168

72-
@BeforeEach
73-
void init() throws IllegalAccessException {
74-
Field convertersField2 = FieldUtils.getDeclaredField(ObjectMapper.class, "_mixIns", true);
75-
SimpleMixInResolver _mixIns = (SimpleMixInResolver) convertersField2.get(objectMapperProvider.jsonMapper());
76-
Field convertersField3 = FieldUtils.getDeclaredField(SimpleMixInResolver.class, "_localMixIns", true);
77-
Map<ClassKey, Class<?>> _localMixIns = (Map<ClassKey, Class<?>>) convertersField3.get(_mixIns);
78-
Iterator<Entry<ClassKey, Class<?>>> it = _localMixIns.entrySet().iterator();
79-
while (it.hasNext()) {
80-
Entry<ClassKey, Class<?>> entry = it.next();
81-
if (entry.getKey().toString().startsWith("org.springframework")) {
82-
springMixins.put(entry.getKey(), entry.getValue());
83-
it.remove();
84-
}
85-
}
86-
87-
}
88-
89-
@AfterEach
90-
void clean() throws IllegalAccessException {
91-
Field convertersField2 = FieldUtils.getDeclaredField(ObjectMapper.class, "_mixIns", true);
92-
SimpleMixInResolver _mixIns = (SimpleMixInResolver) convertersField2.get(objectMapperProvider.jsonMapper());
93-
Field convertersField3 = FieldUtils.getDeclaredField(SimpleMixInResolver.class, "_localMixIns", true);
94-
Map<ClassKey, Class<?>> _localMixIns = (Map<ClassKey, Class<?>>) convertersField3.get(_mixIns);
95-
_localMixIns.putAll(springMixins);
96-
}
9769
}

0 commit comments

Comments
 (0)