project review

bnasslahsen · bnasslahsen · commit f144af0b01a9 · 2020-03-19T16:38:51.000+01:00
diff --git a/springdoc-openapi-common/src/main/java/org/springdoc/core/GenericResponseBuilder.java b/springdoc-openapi-common/src/main/java/org/springdoc/core/GenericResponseBuilder.java
@@ -260,11 +260,7 @@ private Type getReturnType(MethodParameter methodParameter) {
 	}
 
 	public Schema calculateSchema(Components components, Type returnType, JsonView jsonView) {
-		if (isVoid(returnType)) {
-			// if void, no content
-			return null;
-		}
-		return SpringDocAnnotationsUtils.extractSchema(components, returnType, jsonView);
+		return !isVoid(returnType) ? SpringDocAnnotationsUtils.extractSchema(components, returnType, jsonView) : null;
 	}
 
 	private void setContent(String[] methodProduces, Content content,

Original file line number	Diff line number	Diff line change
`@@ -260,11 +260,7 @@ private Type getReturnType(MethodParameter methodParameter) {`
`260`	`260`	`}`
`261`	`261`
`262`	`262`	`public Schema calculateSchema(Components components, Type returnType, JsonView jsonView) {`
`263`		`- if (isVoid(returnType)) {`
`264`		`- // if void, no content`
`265`		`- return null;`
`266`		`- }`
`267`		`- return SpringDocAnnotationsUtils.extractSchema(components, returnType, jsonView);`
	`263`	`+ return !isVoid(returnType) ? SpringDocAnnotationsUtils.extractSchema(components, returnType, jsonView) : null;`
`268`	`264`	`}`
`269`	`265`
`270`	`266`	`private void setContent(String[] methodProduces, Content content,`