Use slug.Make

Author: simonjohansson

go.mod

@@ -28,6 +28,7 @@ require (
 
 require (
 	github.com/concourse/concourse v1.6.1-0.20240109225805-4c9be50ffbcb
+	github.com/gosimple/slug v1.15.0
 	github.com/sirupsen/logrus v1.9.3
 	gopkg.in/yaml.v3 v3.0.1
 )
@@ -39,6 +40,7 @@ require (
 	github.com/charlievieth/fs v0.0.3 // indirect
 	github.com/davecgh/go-spew v1.1.1 // indirect
 	github.com/google/go-cmp v0.7.0 // indirect
+	github.com/gosimple/unidecode v1.0.1 // indirect
 	github.com/hashicorp/go-multierror v1.1.1 // indirect
 	github.com/inconshreveable/mousetrap v1.1.0 // indirect
 	github.com/jessevdk/go-flags v1.6.1 // indirect

go.sum

@@ -40,6 +40,10 @@ github.com/gookit/color v1.5.4 h1:FZmqs7XOyGgCAxmWyPslpiok1k05wmY3SJTytgvYFs0=
 github.com/gookit/color v1.5.4/go.mod h1:pZJOeOS8DM43rXbp4AZo1n9zCU2qjpcRko0b6/QJi9w=
 github.com/gorhill/cronexpr v0.0.0-20180427100037-88b0669f7d75 h1:f0n1xnMSmBLzVfsMMvriDyA75NB/oBgILX2GcHXIQzY=
 github.com/gorhill/cronexpr v0.0.0-20180427100037-88b0669f7d75/go.mod h1:g2644b03hfBX9Ov0ZBDgXXens4rxSxmqFBbhvKv2yVA=
+github.com/gosimple/slug v1.15.0 h1:wRZHsRrRcs6b0XnxMUBM6WK1U1Vg5B0R7VkIf1Xzobo=
+github.com/gosimple/slug v1.15.0/go.mod h1:UiRaFH+GEilHstLUmcBgWcI42viBN7mAb818JrYOeFQ=
+github.com/gosimple/unidecode v1.0.1 h1:hZzFTMMqSswvf0LBJZCZgThIZrpDHFXux9KeGmn6T/o=
+github.com/gosimple/unidecode v1.0.1/go.mod h1:CP0Cr1Y1kogOtx0bJblKzsVWrqYaqfNOnHzpgWw4Awc=
 github.com/hashicorp/errwrap v1.0.0/go.mod h1:YH+1FKiLXxHSkmPseP+kNlulaMuP3n2brvKWEqk/Jc4=
 github.com/hashicorp/errwrap v1.1.0 h1:OxrOeh75EUXMY8TBjag2fzXGZ40LB6IKw45YeGUDY2I=
 github.com/hashicorp/errwrap v1.1.0/go.mod h1:YH+1FKiLXxHSkmPseP+kNlulaMuP3n2brvKWEqk/Jc4=

renderers/actions/run.go

@@ -2,14 +2,15 @@ package actions
 
 import (
 	"fmt"
+	"github.com/gosimple/slug"
 	"github.com/springernature/halfpipe/manifest"
 	"strings"
 )
 
 func (a *Actions) runSteps(task manifest.Run) (steps Steps) {
 	run := Step{
 		Name: task.GetName(),
-		ID:   normaliseForID(task.GetName()),
+		ID:   slug.Make(task.GetName()),
 		Env:  Env(task.Vars),
 	}
 
@@ -42,19 +43,3 @@ func (a *Actions) runSteps(task manifest.Run) (steps Steps) {
 	}
 	return steps
 }
-
-func normaliseForID(name string) string {
-	r := strings.NewReplacer(
-		" ", "-",
-		"_", "-",
-		",", "-",
-		".", "-",
-		"/", "-",
-		"\\", "-",
-		"\"", "-",
-		"(", "-",
-		")", "-",
-	)
-	before, _ := strings.CutSuffix(strings.ReplaceAll(r.Replace(strings.ToLower(name)), "--", "-"), "-")
-	return before
-}