add lint warning if deploy-katee tag is set

Author: robwhitby

linters/deploy-katee.go

@@ -13,6 +13,7 @@ func LintDeployKateeTask(task manifest.DeployKatee, man manifest.Manifest, fs af
 	}
 
 	if task.Tag != "" {
+		errs = append(errs, NewErrDeprecatedField("tag", "now defaults to a unique id instead of gitref or version").AsWarning())
 		if task.Tag != "version" && task.Tag != "gitref" {
 			errs = append(errs, NewErrInvalidField("tag", "must be either 'version' or 'gitref'"))
 		}

linters/errors.go

@@ -12,8 +12,8 @@ var (
 	ErrInvalidField    = newError("invalid field")
 	NewErrInvalidField = func(field string, reason string) Error { return ErrInvalidField.WithValue(field).WithValue(reason) }
 
-	ErrDeprecatedField = newError("deprecated field")
-	NewDeprecatedField = func(field string, reason string) Error { return ErrDeprecatedField.WithValue(field).WithValue(reason) }
+	ErrDeprecatedField    = newError("deprecated field")
+	NewErrDeprecatedField = func(field string, reason string) Error { return ErrDeprecatedField.WithValue(field).WithValue(reason) }
 
 	ErrFileNotFound      = newError("file not found")
 	ErrFileCannotRead    = newError("file cannot be read")

linters/notifications.go

@@ -11,17 +11,17 @@ func LintNotifications(task manifest.Task) (errs []error) {
 	default:
 		n := task.GetNotifications()
 		if len(n.OnSuccess) > 0 {
-			errs = append(errs, NewDeprecatedField("on_success", notificationReasons).AsWarning())
+			errs = append(errs, NewErrDeprecatedField("on_success", notificationReasons).AsWarning())
 		}
 		if n.OnSuccessMessage != "" {
-			errs = append(errs, NewDeprecatedField("on_success_message", notificationReasons).AsWarning())
+			errs = append(errs, NewErrDeprecatedField("on_success_message", notificationReasons).AsWarning())
 		}
 		if len(n.OnFailure) > 0 {
-			errs = append(errs, NewDeprecatedField("on_failure", notificationReasons).AsWarning())
+			errs = append(errs, NewErrDeprecatedField("on_failure", notificationReasons).AsWarning())
 
 		}
 		if len(n.OnFailureMessage) > 0 {
-			errs = append(errs, NewDeprecatedField("on_failure_message", notificationReasons).AsWarning())
+			errs = append(errs, NewErrDeprecatedField("on_failure_message", notificationReasons).AsWarning())
 		}
 
 		for _, n := range append(n.Failure, n.Success...) {

linters/notifications_test.go

@@ -23,10 +23,10 @@ func TestLintNotifications(t *testing.T) {
 		result := LintNotifications(task)
 
 		assert.Len(t, result, 4)
-		assert.Contains(t, result, NewDeprecatedField("on_success", notificationReasons).AsWarning())
-		assert.Contains(t, result, NewDeprecatedField("on_success_message", notificationReasons).AsWarning())
-		assert.Contains(t, result, NewDeprecatedField("on_failure", notificationReasons).AsWarning())
-		assert.Contains(t, result, NewDeprecatedField("on_failure_message", notificationReasons).AsWarning())
+		assert.Contains(t, result, NewErrDeprecatedField("on_success", notificationReasons).AsWarning())
+		assert.Contains(t, result, NewErrDeprecatedField("on_success_message", notificationReasons).AsWarning())
+		assert.Contains(t, result, NewErrDeprecatedField("on_failure", notificationReasons).AsWarning())
+		assert.Contains(t, result, NewErrDeprecatedField("on_failure_message", notificationReasons).AsWarning())
 	})
 
 	t.Run("does nothing for sequence or parallel", func(t *testing.T) {