Fixed the tests and added Restful action spec tests

Author: dilipkrish

springfox-grails/src/main/java/springfox/documentation/grails/RestfulActionSpecificationFactory.java

@@ -1,6 +1,7 @@
 package springfox.documentation.grails;
 
 import com.fasterxml.classmate.TypeResolver;
+import com.google.common.base.Preconditions;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.stereotype.Component;
 
@@ -18,6 +19,10 @@ public RestfulActionSpecificationFactory(TypeResolver resolver) {
 
   @Override
   public ActionSpecification create(GrailsActionContext context) {
+    Preconditions.checkArgument(
+        factoryLookup.containsKey(context.getAction()),
+        String.format("Action %s is not a restful action", context.getAction()));
+
     return factoryLookup.get(context.getAction()).create(context);
   }
 

springfox-grails/src/test/groovy/springfox/documentation/grails/DeleteActionSpecificationFactorySpec.groovy

@@ -29,7 +29,7 @@ class DeleteActionSpecificationFactorySpec extends Specification {
     then:
       spec.consumes == [MediaType.APPLICATION_JSON] as Set
       spec.produces == [MediaType.APPLICATION_JSON] as Set
-      spec.supportedMethods == [RequestMethod.GET] as Set
+      spec.supportedMethods == [RequestMethod.POST] as Set
       spec.parameters.size() == 1
       spec.parameters[0].parameterType == resolver.resolve(Integer)
       spec.parameters[0].parameterIndex == 1

springfox-grails/src/test/groovy/springfox/documentation/grails/RestfulActionSpecificationFactorySpec.groovy

@@ -0,0 +1,43 @@
+package springfox.documentation.grails
+
+import com.fasterxml.classmate.TypeResolver
+import grails.core.GrailsControllerClass
+import grails.core.GrailsDomainClass
+import grails.core.GrailsDomainClassProperty
+import spock.lang.Specification
+
+class RestfulActionSpecificationFactorySpec extends Specification {
+  def controller = Mock(GrailsControllerClass)
+  def domain = Mock(GrailsDomainClass)
+  def identifierProperty = Mock(GrailsDomainClassProperty)
+
+  def setup() {
+    controller.clazz >> AController
+    domain.clazz >> ADomain
+    domain.identifier >> identifierProperty
+    domain.identifier.type >> Integer
+  }
+
+  def "Resolves all restful actions"() {
+    given:
+      def resolver = new TypeResolver()
+      def sut = new RestfulActionSpecificationFactory(resolver)
+    when:
+      def actionSpec = sut.create(new GrailsActionContext(controller, domain, action.toLowerCase()))
+    then:
+      actionSpec.handlerMethod.method.name == action
+    where:
+      action << ["index", "save", "show", "edit", "update", "delete", "patch", "create"]
+  }
+
+  def "Resolves ONLY restful actions"() {
+    given:
+      def resolver = new TypeResolver()
+      def sut = new RestfulActionSpecificationFactory(resolver)
+    when:
+      sut.create(new GrailsActionContext(controller, domain, "unknown"))
+    then:
+      def exception = thrown(IllegalArgumentException)
+      exception.message.contains("Action unknown is not a restful action")
+  }
+}