Fix: Enable / Disabled #39

Author: tmenzel27

CHANGELOG.md

@@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 - Migrated to Svelte 5
+- `installed` is not a property of Plugin anymore
 
 ### Removed
 - Removed customElement as it isn't needed

src/plugin-store-item.svelte

@@ -51,7 +51,7 @@ function installExternalPlugin(plugin: Plugin) {
 	const currentPlugins = getStoredPlugins();
 
 	const pluginCopy = { ...plugin };
-	pluginCopy.installed = true;
+	pluginCopy.active = true;
 	currentPlugins.push(pluginCopy);
 
 	localPlugins = currentPlugins; 
@@ -64,22 +64,23 @@ function installExternalPlugin(plugin: Plugin) {
 function uninstallExternalPlugin(plugin: Plugin) {
 	const currentPlugins = getStoredPlugins();
 	const updatedPlugins = currentPlugins.filter((it) => it.name !== plugin.name);
+	
 	localPlugins = updatedPlugins;
 
 	dispatchConfigurePlugin(plugin, true);
 	console.log("Uninstalled external plugin:", plugin.name);
 }
 
-// Enables/disables plugin by toggling the "installed" property.
+// Enables/disables plugin by toggling the "active" property.
 function toggleOfficialPlugin(plugin: Plugin, isEnabled: boolean) {
 	const currentPlugins = getStoredPlugins();
 	const foundPlugin = currentPlugins.find((it) => it.name === plugin.name);
-	if (foundPlugin) {
-		foundPlugin.installed = isEnabled;
-	}
-
+    if (foundPlugin) {
+        foundPlugin.active = isEnabled;
+    }
+    
 	localPlugins = currentPlugins;
-	plugin.installed = isEnabled;
+    plugin.active = isEnabled;
 
 	dispatchConfigurePlugin(plugin);
 	console.log("Set toggle state for", plugin.name);
@@ -150,7 +151,7 @@ function getPluginIcon(plugin: Plugin) {
             </div>
         </plugin-store-item-meta--wrapper>
     </plugin-store-item-meta>
-    {#if plugin.installed}
+    {#if plugin.active}
         {#if plugin.official}
             <Button variant="outlined" onclick={() => toggleOfficialPlugin(plugin, false)}>
                 Disable
@@ -171,7 +172,7 @@ function getPluginIcon(plugin: Plugin) {
             Enable
         </Button>
     {:else}
-        {#if localPlugins.includes(plugin)}
+        {#if localPlugins.some(p => p.name === plugin.name)}
             <SplitButton label="Enable" onclick={() => {toggleOfficialPlugin(plugin, true)}} onmenuOpen={() => openPluginMenu(index)}>
                 <Menu bind:this={menus[index]} open={menuStates[index]} anchorCorner="BOTTOM_LEFT" style="left: -70px;">
                     <List>

src/plugin-store.svelte

@@ -46,7 +46,8 @@ function combineAllPlugins(local: Plugin[], external: Plugin[]): Plugin[] {
 }
 
 function filterInstalledPlugins(plugin: Plugin, isChecked: boolean): boolean {
-	return !isChecked || localPlugins.includes(plugin);
+	if (!isChecked) return true;
+	return localPlugins.some(p => p.name === plugin.name && p.active);
 }
 
 function filterSearchResults(plugin: Plugin, filter: string): boolean {

src/plugin-store.ts

@@ -6,7 +6,8 @@ export type Plugin = {
 	kind: PluginKind;
 	requireDoc?: boolean;
 	position?: MenuPosition;
-	installed: boolean;
+	active: boolean;
+	activeByDefault?: boolean;
 	official?: boolean;
 	description?: string;
 };