Lint

Author: mpetrun5

api/handlers/util.go

@@ -18,7 +18,7 @@ func (b *BigInt) UnmarshalJSON(data []byte) error {
 	}
 
 	s := strings.Trim(string(data), "\"")
-	_, ok := b.Int.SetString(s, 10)
+	_, ok := b.SetString(s, 10)
 	if !ok {
 		return fmt.Errorf("failed to parse big.Int from %s", s)
 	}

chains/evm/config.go

@@ -107,7 +107,7 @@ func NewEVMConfig(chainConfig map[string]interface{}) (*EVMConfig, error) {
 		confirmations[usd] = confirmation
 	}
 
-	c.GeneralChainConfig.ParseFlags()
+	c.ParseFlags()
 	config := &EVMConfig{
 		GeneralChainConfig: c.GeneralChainConfig,
 		Admin:              c.Admin,

comm/p2p/util.go

@@ -26,7 +26,7 @@ func ReadStream(r *bufio.Reader) ([]byte, error) {
 
 // WriteStream writes the message to stream
 func WriteStream(msg []byte, w *bufio.Writer) error {
-	_, err := w.WriteString(fmt.Sprintf("%s\n", string(msg[:])))
+	_, err := fmt.Fprintf(w, "%s\n", string(msg[:]))
 	if err != nil {
 		return err
 	}

metrics/host.go

@@ -5,20 +5,19 @@ import (
 	"time"
 
 	"go.opentelemetry.io/otel/metric"
-	api "go.opentelemetry.io/otel/metric"
 )
 
 type HostMetrics struct {
-	startTimeGauge api.Int64ObservableGauge
+	startTimeGauge metric.Int64ObservableGauge
 }
 
 // NewHostMetrics initializes metrics related to the relayer host
 func NewHostMetrics(ctx context.Context, meter metric.Meter, opts metric.MeasurementOption) (*HostMetrics, error) {
 	startTime := time.Now().Unix()
 	startTimeGauge, err := meter.Int64ObservableGauge(
 		"relayer.StartTimeSeconds",
-		api.WithDescription("Start time of the relayer"),
-		api.WithInt64Callback(func(ctx context.Context, result api.Int64Observer) error {
+		metric.WithDescription("Start time of the relayer"),
+		metric.WithInt64Callback(func(ctx context.Context, result metric.Int64Observer) error {
 			result.Observe(startTime, opts)
 			return nil
 		}),

metrics/mpc.go

@@ -5,12 +5,11 @@ import (
 
 	"github.com/libp2p/go-libp2p/core/peer"
 	"go.opentelemetry.io/otel/metric"
-	api "go.opentelemetry.io/otel/metric"
 )
 
 type MpcMetrics struct {
-	totalRelayersGauge     api.Int64ObservableGauge
-	availableRelayersGauge api.Int64ObservableGauge
+	totalRelayersGauge     metric.Int64ObservableGauge
+	availableRelayersGauge metric.Int64ObservableGauge
 	totalRelayerCount      *int64
 	availableRelayerCount  *int64
 }
@@ -21,22 +20,22 @@ func NewMpcMetrics(ctx context.Context, meter metric.Meter, opts metric.Measurem
 	availableRelayerCount := new(int64)
 	totalRelayersGauge, err := meter.Int64ObservableGauge(
 		"relayer.TotalRelayers",
-		api.WithInt64Callback(func(context context.Context, result api.Int64Observer) error {
+		metric.WithInt64Callback(func(context context.Context, result metric.Int64Observer) error {
 			result.Observe(*totalRelayerCount, opts)
 			return nil
 		}),
-		api.WithDescription("Total number of relayers currently in the subset"),
+		metric.WithDescription("Total number of relayers currently in the subset"),
 	)
 	if err != nil {
 		return nil, err
 	}
 	availableRelayersGauge, err := meter.Int64ObservableGauge(
 		"relayer.AvailableRelayers",
-		api.WithInt64Callback(func(context context.Context, result api.Int64Observer) error {
+		metric.WithInt64Callback(func(context context.Context, result metric.Int64Observer) error {
 			result.Observe(*availableRelayerCount, opts)
 			return nil
 		}),
-		api.WithDescription("Available number of relayers currently in the subset"),
+		metric.WithDescription("Available number of relayers currently in the subset"),
 	)
 	if err != nil {
 		return nil, err

tss/ecdsa/keygen/keygen_test.go

@@ -32,7 +32,7 @@ func (s *KeygenTestSuite) Test_ValidKeygenProcess() {
 	coordinators := []*tss.Coordinator{}
 	processes := []tss.TssProcess{}
 
-	for _, host := range s.CoordinatorTestSuite.Hosts {
+	for _, host := range s.Hosts {
 		communication := tsstest.TestCommunication{
 			Host:          host,
 			Subscriptions: make(map[comm.SubscriptionID]chan *comm.WrappedMessage),
@@ -68,7 +68,7 @@ func (s *KeygenTestSuite) Test_KeygenTimeout() {
 	communicationMap := make(map[peer.ID]*tsstest.TestCommunication)
 	coordinators := []*tss.Coordinator{}
 	processes := []tss.TssProcess{}
-	for _, host := range s.CoordinatorTestSuite.Hosts {
+	for _, host := range s.Hosts {
 		communication := tsstest.TestCommunication{
 			Host:          host,
 			Subscriptions: make(map[comm.SubscriptionID]chan *comm.WrappedMessage),