Skip to content

Commit 2afc20b

Browse files
Merge pull request #93 from spryker/bugfix/supesc-946-delete-triggered-on-0-events
SUPESC-946 EventBehaviorFacade::triggerRuntimeEvents triggers delete when there are 0 event triggered
2 parents e30c7c3 + f2c06dc commit 2afc20b

File tree

3 files changed

+3
-9
lines changed

3 files changed

+3
-9
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ jobs:
6262
run: |
6363
echo "::set-output name=dir::$(composer config cache-files-dir)"
6464
65-
- uses: actions/cache@v2
65+
- uses: actions/cache@v3
6666
with:
6767
path: ${{ steps.composer-cache.outputs.dir }}
6868
key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
@@ -120,7 +120,7 @@ jobs:
120120
run: |
121121
echo "::set-output name=dir::$(composer config cache-files-dir)"
122122
123-
- uses: actions/cache@v2
123+
- uses: actions/cache@v3
124124
with:
125125
path: ${{ steps.composer-cache.outputs.dir }}
126126
key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}

src/Spryker/Zed/EventBehavior/Business/Model/TriggerManager.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ public function triggerRuntimeEvents()
127127
$offset += $limit;
128128
} while ($countEvents === $limit);
129129

130-
if ($countEvents === $triggeredEvents) {
130+
if ($countEvents === $triggeredEvents && $triggeredEvents > 0) {
131131
$this->eventBehaviorEntityManager->deleteEventBehaviorEntityByProcessId($processId);
132132

133133
return;

src/Spryker/Zed/EventBehavior/Persistence/Propel/Behavior/EventBehavior.php

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -105,33 +105,27 @@ public function addParameter(array $parameter): void
105105
{
106106
$parameter = array_change_key_case($parameter, CASE_LOWER);
107107

108-
// @phpstan-ignore-next-line
109108
$this->parameters[$parameter['name']] = [];
110109

111110
if (!isset($parameter['column'])) {
112111
throw new PropelException(sprintf('"column" attribute for %s event behavior is missing', $parameter['name']));
113112
}
114113

115-
// @phpstan-ignore-next-line
116114
$this->parameters[$parameter['name']]['column'] = $parameter['column'];
117115

118116
if (isset($parameter['value'])) {
119-
// @phpstan-ignore-next-line
120117
$this->parameters[$parameter['name']]['value'] = $parameter['value'];
121118
}
122119

123120
if (isset($parameter['operator'])) {
124-
// @phpstan-ignore-next-line
125121
$this->parameters[$parameter['name']]['operator'] = $parameter['operator'];
126122
}
127123

128124
if (isset($parameter['keep-original'])) {
129-
// @phpstan-ignore-next-line
130125
$this->parameters[$parameter['name']]['keep-original'] = $parameter['keep-original'];
131126
}
132127

133128
if (isset($parameter['keep-additional'])) {
134-
// @phpstan-ignore-next-line
135129
$this->parameters[$parameter['name']]['keep-additional'] = $parameter['keep-additional'];
136130
}
137131
}

0 commit comments

Comments
 (0)