Merge pull request #91 from spryker/feature/cc-33982/dev-ps-optimization

P&S optimisation

Author: spryker-release-bot

src/Spryker/Shared/EventBehavior/EventBehaviorConstants.php

@@ -51,4 +51,15 @@ interface EventBehaviorConstants
      * @var string
      */
     public const ENABLE_INSTANCE_POOLING = 'EVENT_BEHAVIOR:ENABLE_INSTANCE_POOLING';
+
+    /**
+     * Specification:
+     * - Recommended maximum data size for event messages in KB.
+     * - Used to log a warning if the event message data size exceeds this limit.
+     *
+     * @api
+     *
+     * @var string
+     */
+    public const MAX_EVENT_MESSAGE_DATA_SIZE = 'EVENT_BEHAVIOR:MAX_EVENT_MESSAGE_DATA_SIZE';
 }

src/Spryker/Zed/EventBehavior/EventBehaviorConfig.php

@@ -111,4 +111,18 @@ public static function isEventBehaviorDisabled()
     {
         return static::$isEventDisabled;
     }
+
+    /**
+     * Specification:
+     * - Recommended maximum data size for event messages in KB.
+     * - Used to log a warning if the event message data size exceeds this limit.
+     *
+     * @api
+     *
+     * @return int
+     */
+    public function getMaxEventMessageDataSize(): int
+    {
+        return $this->get(EventBehaviorConstants::MAX_EVENT_MESSAGE_DATA_SIZE, 256);
+    }
 }

src/Spryker/Zed/EventBehavior/Persistence/Propel/Behavior/EventBehavior.php

@@ -13,9 +13,15 @@
 use Propel\Generator\Model\Table;
 use Propel\Generator\Util\PhpParser;
 use Propel\Runtime\Exception\PropelException;
+use Spryker\Zed\Kernel\BundleConfigResolverAwareTrait;
 
+/**
+ * @method \Spryker\Zed\EventBehavior\EventBehaviorConfig getConfig()
+ */
 class EventBehavior extends Behavior
 {
+    use BundleConfigResolverAwareTrait;
+
     /**
      * @var string
      */
@@ -427,6 +433,8 @@ protected function getForeignKeys()
      */
     protected function addSaveEventBehaviorEntityChangeMethod()
     {
+        $maxEventMessageDataSize = $this->getConfig()->getMaxEventMessageDataSize();
+
         return "
 /**
  * @param array \$data
@@ -435,10 +443,24 @@ protected function addSaveEventBehaviorEntityChangeMethod()
  */
 protected function saveEventBehaviorEntityChange(array \$data)
 {
+    \$encodedData = json_encode(\$data);
+    \$dataLength = strlen(\$encodedData);
+
+    if (\$dataLength > $maxEventMessageDataSize * 1024) {
+        \$warningMessage = sprintf(
+            '%s event message data size (%d KB) exceeds the allowable limit of %d KB. Please reduce the event message size or it might disrupt P&S process.',
+            (\$data['event'] ?? ''),
+            \$dataLength / 1024,
+            $maxEventMessageDataSize,
+        );
+
+        \$this->log(\$warningMessage, \\Propel\\Runtime\\Propel::LOG_WARNING);
+    }
+
     \$isInstancePoolingDisabledSuccessfully = \\Propel\\Runtime\\Propel::disableInstancePooling();
 
     \$spyEventBehaviorEntityChange = new \\Orm\\Zed\\EventBehavior\\Persistence\\SpyEventBehaviorEntityChange();
-    \$spyEventBehaviorEntityChange->setData(json_encode(\$data));
+    \$spyEventBehaviorEntityChange->setData(\$encodedData);
     \$spyEventBehaviorEntityChange->setProcessId(\\Spryker\\Zed\\Kernel\\RequestIdentifier::getRequestId());
     \$spyEventBehaviorEntityChange->save();