Skip to content

Commit c2e59bd

Browse files
alxndrsnspwoodcock
authored andcommitted
test/db-migrations: resolve TODO ref migration order (getodk#1458)
Knex sorts migration files at https://github.com/knex/knex/blob/823c7b60f74fb16bcb8a8230afe1fea6673c2bd0/lib/migrate/sources/fs-migrations.js#L70 Encountered while working on getodk#1363
1 parent 4c0d0b1 commit c2e59bd

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

test/db-migrations/migrator.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ function loadMigrationsList() {
7575
const migrations = fs.readdirSync(migrationsDir)
7676
.filter(f => f.endsWith('.js'))
7777
.map(f => f.replace(/\.js$/, ''))
78-
.sort(); // TODO check that this is how knex sorts migration files
78+
.sort(); // match sorting in pg-migrator and knex's fs-migrations.js
7979
log();
8080
log('All migrations:');
8181
log();

0 commit comments

Comments
 (0)