Editor: Fix introducing completions after a dot

Also, expand test to check that an entry selected in the completion
widget when it's shown after a dot is introduced as expected.

Author: ccordoba12

spyder/plugins/editor/widgets/base.py

@@ -952,13 +952,30 @@ def insert_completion(self, completion, completion_position):
                 current_text, start_position = result
                 end_position = start_position + len(current_text)
 
-                # Check if the completion position is in the expected range
-                if not (start_position <= completion_position <= end_position):
-                    return
-                cursor.setPosition(start_position)
-
-                # Remove the word under the cursor
-                cursor.setPosition(end_position, QTextCursor.KeepAnchor)
+                # Remove text under cursor only if it's not an autocompletion
+                # character
+                is_auto_completion_character = False
+                if self.objectName() == 'console':
+                    if current_text == '.':
+                        is_auto_completion_character = True
+                else:
+                    if current_text in self.auto_completion_characters:
+                        is_auto_completion_character = True
+
+                if not is_auto_completion_character:
+                    # Check if the completion position is in the expected range
+                    if not (
+                        start_position <= completion_position <= end_position
+                    ):
+                        return
+                    cursor.setPosition(start_position)
+
+                    # Remove the word under the cursor
+                    cursor.setPosition(end_position, QTextCursor.KeepAnchor)
+                else:
+                    # Check if we are in the correct position
+                    if cursor.position() != completion_position:
+                        return
             else:
                 # Check if we are in the correct position
                 if cursor.position() != completion_position:

spyder/plugins/editor/widgets/tests/test_introspection.py

@@ -1193,6 +1193,7 @@ def test_dot_completions(completions_codeeditor, qtbot):
     """
     code_editor, _ = completions_codeeditor
     completion = code_editor.completion_widget
+    code_editor.toggle_code_snippets(False)
 
     # Import module and check completions are shown for it after writing a dot
     # after it
@@ -1208,6 +1209,17 @@ def test_dot_completions(completions_codeeditor, qtbot):
     qtbot.wait(500)
     assert completion.isVisible()
 
+    # Select a raondom entry in the completion widget
+    entry_index = random.randint(0, 30)
+    inserted_entry = completion.completion_list[entry_index]['insertText']
+    for _ in range(entry_index):
+        qtbot.keyPress(completion, Qt.Key_Down, delay=50)
+
+    # Insert completion and check that the inserted text is the expected one
+    qtbot.keyPress(completion, Qt.Key_Enter)
+    qtbot.wait(500)
+    assert code_editor.toPlainText() == f'import math\nmath.{inserted_entry}'
+
 
 @pytest.mark.slow
 @pytest.mark.order(1)