fix: default aws perf harness region to us-west-2

Author: sqdshguy

docs/BENCHMARK.md

@@ -75,10 +75,11 @@ If you do not want to benchmark on your laptop/network, use the AWS CLI harness:
 2. Run base vs head comparison on an ephemeral EC2 runner (Spot by default, auto-terminates):
 
 ```bash
-./scripts/aws-perf/ec2-compare.sh --region us-east-1
+./scripts/aws-perf/ec2-compare.sh
 ```
 
 Note: the runner clones from `origin` by default, so both refs must exist in the remote repository (push your branch/commit first if needed).
+Default region is `us-west-2`; pass `--region <aws-region>` to override.
 
 The script:
 
@@ -97,7 +98,7 @@ Useful options:
 Safety cleanup:
 
 ```bash
-./scripts/aws-perf/cleanup-stale.sh us-east-1
+./scripts/aws-perf/cleanup-stale.sh
 ```
 
 This terminates old perf instances tagged with expired TTL metadata.

scripts/aws-perf/cleanup-stale.sh

@@ -1,20 +1,54 @@
 #!/usr/bin/env bash
 set -euo pipefail
 
-if [[ "${1:-}" == "-h" || "${1:-}" == "--help" ]]; then
+DEFAULT_REGION="us-west-2"
+REGION="${AWS_REGION:-${AWS_DEFAULT_REGION:-$DEFAULT_REGION}}"
+POSITIONAL_REGION=""
+
+usage() {
   cat <<'EOF'
-Usage: scripts/aws-perf/cleanup-stale.sh <region>
+Usage: scripts/aws-perf/cleanup-stale.sh [options] [region]
+
+Options:
+  --region <aws-region>   AWS region (default: us-west-2)
+  -h, --help              Show help
 
-Example:
-  scripts/aws-perf/cleanup-stale.sh us-east-1
+Examples:
+  scripts/aws-perf/cleanup-stale.sh
+  scripts/aws-perf/cleanup-stale.sh --region us-west-2
+  scripts/aws-perf/cleanup-stale.sh us-west-2
 EOF
-  exit 0
-fi
+}
+
+while [[ $# -gt 0 ]]; do
+  case "$1" in
+    --region)
+      if [[ $# -lt 2 ]]; then
+        echo "[aws-perf-cleanup] ERROR: --region requires a value" >&2
+        usage
+        exit 1
+      fi
+      REGION="$2"
+      shift 2
+      ;;
+    -h|--help)
+      usage
+      exit 0
+      ;;
+    --*)
+      echo "[aws-perf-cleanup] ERROR: unknown argument: $1" >&2
+      usage
+      exit 1
+      ;;
+    *)
+      POSITIONAL_REGION="$1"
+      shift
+      ;;
+  esac
+done
 
-REGION="${1:-${AWS_REGION:-${AWS_DEFAULT_REGION:-}}}"
-if [[ -z "$REGION" ]]; then
-  echo "[aws-perf-cleanup] ERROR: region is required (arg1 or AWS_REGION)" >&2
-  exit 1
+if [[ -n "$POSITIONAL_REGION" ]]; then
+  REGION="$POSITIONAL_REGION"
 fi
 
 NOW_EPOCH="$(date +%s)"

scripts/aws-perf/ec2-compare.sh

@@ -9,7 +9,8 @@ INSTANCE_ID=""
 SHOULD_CLEANUP=true
 PARAMS_FILE=""
 
-REGION="${AWS_REGION:-${AWS_DEFAULT_REGION:-}}"
+DEFAULT_REGION="us-west-2"
+REGION="${AWS_REGION:-${AWS_DEFAULT_REGION:-$DEFAULT_REGION}}"
 INSTANCE_PROFILE_NAME="wreq-js-perf-ssm-profile"
 INSTANCE_TYPE="c6i.large"
 USE_SPOT=true
@@ -33,7 +34,7 @@ usage() {
 Usage: scripts/aws-perf/ec2-compare.sh [options]
 
 Options:
-  --region <aws-region>
+  --region <aws-region>             AWS region (default: us-west-2)
   --instance-profile <name>         IAM instance profile with AmazonSSMManagedInstanceCore
   --instance-type <type>            EC2 instance type (default: c6i.large)
   --subnet-id <subnet-id>           Optional; auto-detected when omitted
@@ -136,9 +137,6 @@ requires grep
 requires mktemp
 requires node
 
-if [[ -z "$REGION" ]]; then
-  REGION="$(aws configure get region 2>/dev/null || true)"
-fi
 [[ -n "$REGION" ]] || fail "AWS region is required (use --region or set AWS_REGION)"
 
 mkdir -p "$OUTPUT_DIR"