Disable $named params support in favor of $$-strings

Author: nene

src/languages/duckdb/duckdb.formatter.ts

@@ -163,7 +163,8 @@ export const duckdb: DialectOptions = {
     ],
     identTypes: [`""-qq`],
     identChars: { rest: '$' },
-    paramTypes: { positional: true, numbered: ['$'], named: ['$'], quoted: ['$'] },
+    // TODO: named params $foo currently conflict with $$-quoted strings
+    paramTypes: { positional: true, numbered: ['$'], quoted: ['$'] },
     operators: [
       // Arithmetic:
       '//',

test/duckdb.test.ts

@@ -124,7 +124,8 @@ describe('DuckDBFormatter', () => {
     'INTERSECT ALL',
   ]);
   supportsReturning(format);
-  supportsParams(format, { positional: true, numbered: ['$'], named: ['$'], quoted: ['$""'] });
+  // TODO: named params $foo currently conflict with $$-quoted strings
+  supportsParams(format, { positional: true, numbered: ['$'], quoted: ['$""'] });
   supportsWindow(format);
   supportsLimiting(format, { limit: true, offset: true });
   supportsDataTypeCase(format);

test/features/strings.ts

@@ -272,8 +272,7 @@ export default function supportsStrings(format: FormatFn, stringTypes: StringTyp
       `);
     });
 
-    // TODO: this conflicts with named parameter syntax: $foo
-    it.skip('supports tagged dollar-quoted strings', () => {
+    it('supports tagged dollar-quoted strings', () => {
       expect(format('$xxx$foo $$ LEFT JOIN $yyy$ bar$xxx$')).toBe(
         '$xxx$foo $$ LEFT JOIN $yyy$ bar$xxx$'
       );