ARRAY[] not supported in redshift

[nathanmmiller]

Describe the bug
Example sql: select thing from table where id = any(array[1, 2])

Expected behavior
It should format at all

Actual behavior
It completely crashes

Parse error: Unexpected "[1, 2])" at line 1 column 45. SQL dialect used: "redshift".

Please report this at Github issues page.

Stack Trace:

Error: Parse error: Unexpected "[1, 2])" at line 1 column 45.
SQL dialect used: "redshift".

Usage

• How are you calling / using the library? This fails even in the demo website
• What SQL language(s) does this apply to? Redshift
• Which SQL Formatter version are you using? 15.6.1

[nathanmmiller]

@nene any chance this is fixable? Redshift supports both array() as a function and array[] as a datatype, which means this is valid syntax. I tried implementing a fix in a fork by using extraParens but then tests fail because it doesn't convert ArrAY to ARRAY because it can't disambiguate between when it's a function and a datatype.

[nene]

Thanks for reporting. Can you please point me at Redshift documentation that mentions this syntax. I only managed to find mention of array.accessor[1] syntax. I admit that finding clear syntax documentation for Redshift has been hard to come by in general.

It's not that I don't believe you, but I'd really like to have a official source to back up all claims about syntax.

[nathanmmiller]

@nene you're not wrong that redshift documentation leaves something to be desired... we use array[] so I know it works in redshift (redshift engineers told us to start using it). But finding documentation was not easy... the best I have is this: https://docs.aws.amazon.com/redshift/latest/dg/r_SUPER_type.html

[nene]

Implemented support for ARRAY[] syntax.

Do you know if Redshift perhaps also supports accessing arrays like this:

SELECT column[2] FROM tbl

Ignore that. This is already supported by the formatter :)

[nene]

Released in 15.6.8

[nathanmmiller]

Implemented support for ARRAY[] syntax.

Do you know if Redshift perhaps also supports accessing arrays like this:

SELECT column[2] FROM tbl
Ignore that. This is already supported by the formatter :)

I can confirm it does in fact support this syntax, yes. But good to know we're good already!

Thank you for the quick turnaround @nene - I've already ingested the new version and can confirm we're all good. Much appreciated!