Skip to content

Commit 1e7b28f

Browse files
authored
Move to the LLVM backend of emscripten (#356)
* Update emsdk * emsdk 1.39.9
1 parent 72b5dcd commit 1e7b28f

File tree

3 files changed

+4
-7
lines changed

3 files changed

+4
-7
lines changed

.github/workflows/CI.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,13 @@ jobs:
77
runs-on: ubuntu-latest
88
steps:
99
- uses: actions/checkout@v1
10-
- uses: mymindstorm/setup-emsdk@v1
11-
with: {version: '1.39.8-fastcomp'}
10+
- uses: mymindstorm/setup-emsdk@b6b33c4
11+
with: {version: '1.39.9'}
1212
- uses: actions/cache@v1
1313
id: cache
1414
with:
1515
path: ~/.emscripten_cache
16-
key: emscripten-1.39.8-fastcomp
16+
key: emscripten-1.39.9
1717
- name: make
1818
run: make
1919
- uses: actions/upload-artifact@master

.github/workflows/release.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,7 @@ jobs:
1313
steps:
1414
- uses: actions/checkout@v1
1515
- uses: mymindstorm/setup-emsdk@v1
16-
with:
17-
version: '1.39.8-fastcomp'
16+
with: {version: '1.39.9'}
1817
- name: make
1918
run: make
2019
- name: Create Release

src/api.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -875,8 +875,6 @@ Module["onRuntimeInitialized"] = function onRuntimeInitialized() {
875875
@return {Database} The database object. Useful for method chaining
876876
*/
877877
Database.prototype["create_function"] = function create_function(name, func) {
878-
// TODO : add type arguments for compatibility with the llvm backend
879-
// https://emscripten.org/docs/porting/connecting_cpp_and_javascript/Interacting-with-code.html#calling-javascript-functions-as-function-pointers-from-c
880878
var func_ptr;
881879
function wrapped_func(cx, argc, argv) {
882880
var result;

0 commit comments

Comments
 (0)