Skip to content

Commit 282f6f6

Browse files
committed
Make the javascript more idiomatic
The coffee to javascript conversion was done with little manual review, and we were left with many while loops that should have been for loops
1 parent c43a89d commit 282f6f6

File tree

1 file changed

+6
-18
lines changed

1 file changed

+6
-18
lines changed

src/api.js

Lines changed: 6 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -358,10 +358,8 @@ Module["onRuntimeInitialized"] = function onRuntimeInitialized() {
358358
var size = sqlite3_column_bytes(this.stmt, pos);
359359
var ptr = sqlite3_column_blob(this.stmt, pos);
360360
var result = new Uint8Array(size);
361-
var i = 0;
362-
while (i < size) {
361+
for (var i = 0; i < size; i += 1) {
363362
result[i] = HEAP8[ptr + i];
364-
i += 1;
365363
}
366364
return result;
367365
};
@@ -382,9 +380,8 @@ Module["onRuntimeInitialized"] = function onRuntimeInitialized() {
382380
this["step"]();
383381
}
384382
var results1 = [];
385-
var field = 0;
386383
var ref = sqlite3_data_count(this.stmt);
387-
while (field < ref) {
384+
for (var field = 0; field < ref; field += 1) {
388385
switch (sqlite3_column_type(this.stmt, field)) {
389386
case SQLITE_INTEGER:
390387
case SQLITE_FLOAT:
@@ -399,7 +396,6 @@ Module["onRuntimeInitialized"] = function onRuntimeInitialized() {
399396
default:
400397
results1.push(null);
401398
}
402-
field += 1;
403399
}
404400
return results1;
405401
};
@@ -416,11 +412,9 @@ Module["onRuntimeInitialized"] = function onRuntimeInitialized() {
416412
*/
417413
Statement.prototype["getColumnNames"] = function getColumnNames() {
418414
var results1 = [];
419-
var i = 0;
420415
var ref = sqlite3_column_count(this.stmt);
421-
while (i < ref) {
416+
for (var i = 0; i < ref; i += 1) {
422417
results1.push(sqlite3_column_name(this.stmt, i));
423-
i += 1;
424418
}
425419
return results1;
426420
};
@@ -445,12 +439,9 @@ Module["onRuntimeInitialized"] = function onRuntimeInitialized() {
445439
var values = this["get"](params);
446440
var names = this["getColumnNames"]();
447441
var rowObject = {};
448-
var i = 0;
449-
var len = names.length;
450-
while (i < len) {
442+
for (var i = 0; i < names.length; i += 1) {
451443
var name = names[i];
452444
rowObject[name] = values[i];
453-
i += 1;
454445
}
455446
return rowObject;
456447
};
@@ -504,12 +495,11 @@ Module["onRuntimeInitialized"] = function onRuntimeInitialized() {
504495
};
505496

506497
Statement.prototype.bindNumber = function bindNumber(num, pos) {
507-
var bindfunc;
508498
if (pos == null) {
509499
pos = this.pos;
510500
this.pos += 1;
511501
}
512-
bindfunc = (
502+
var bindfunc = (
513503
num === (num | 0)
514504
? sqlite3_bind_int
515505
: sqlite3_bind_double
@@ -577,10 +567,8 @@ Module["onRuntimeInitialized"] = function onRuntimeInitialized() {
577567
@nodoc
578568
*/
579569
Statement.prototype.bindFromArray = function bindFromArray(values) {
580-
var num = 0;
581-
while (num < values.length) {
570+
for (var num = 0; num < values.length; num += 1) {
582571
this.bindValue(values[num], num + 1);
583-
num += 1;
584572
}
585573
return true;
586574
};

0 commit comments

Comments
 (0)