Skip to content

Commit 8df3e98

Browse files
Add elasticdl_client test execution in build_and_test.sh (#2124)
* Add elasticdl_client test in build_and_test.sh * Install the dependency for elasticdl_client and elasticdl_preprocessing in the Dockerfile of the elasticdl:dev image * Fix unit test failure.
1 parent b5f3609 commit 8df3e98

File tree

4 files changed

+26
-4
lines changed

4 files changed

+26
-4
lines changed

elasticdl/docker/Dockerfile

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,21 @@ RUN apt-get -qq update && \
99
shellcheck libeigen3-dev clang-format > /dev/null && \
1010
python -m pip install --quiet --upgrade pip
1111

12+
COPY elasticdl_client/requirements.txt /requirements.txt
13+
RUN python -m pip install --quiet -r /requirements.txt \
14+
--extra-index-url=$EXTRA_PYPI_INDEX \
15+
&& rm /requirements.txt
16+
17+
COPY elasticdl_preprocessing/requirements.txt /requirements.txt
18+
RUN python -m pip install --quiet -r /requirements.txt \
19+
--extra-index-url=$EXTRA_PYPI_INDEX \
20+
&& rm /requirements.txt
21+
22+
COPY elasticdl_preprocessing/requirements-dev.txt /requirements-dev.txt
23+
RUN python -m pip install --quiet -r /requirements-dev.txt \
24+
--extra-index-url=$EXTRA_PYPI_INDEX \
25+
&& rm /requirements-dev.txt
26+
1227
COPY elasticdl/requirements.txt /requirements.txt
1328
RUN python -m pip install --quiet -r /requirements.txt \
1429
--extra-index-url=$EXTRA_PYPI_INDEX \

elasticdl_client/common/args.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,14 @@
1515

1616
from elasticdl_client.common.constants import DistributionStrategy
1717

18+
DEFAULT_BASE_IMAGE = "python:3.6"
19+
1820

1921
def add_zoo_init_params(parser):
2022
parser.add_argument(
2123
"--base_image",
2224
type=str,
23-
default="python:3.6",
25+
default=DEFAULT_BASE_IMAGE,
2426
help="Base Docker image.",
2527
)
2628
parser.add_argument(

elasticdl_client/tests/arg_parser_test.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313

1414
import unittest
1515

16+
from elasticdl_client.common.args import DEFAULT_BASE_IMAGE
1617
from elasticdl_client.main import build_argument_parser
1718

1819

@@ -23,7 +24,7 @@ def setUp(self):
2324
def test_parse_zoo_init(self):
2425
args = ["zoo", "init"]
2526
args = self._parser.parse_args(args)
26-
self.assertEqual(args.base_image, "python:latest")
27+
self.assertEqual(args.base_image, DEFAULT_BASE_IMAGE)
2728
args.func(args)
2829

2930
args = ["zoo", "init", "--base_image=elasticdl:base"]

scripts/build_and_test.sh

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,11 @@ sh scripts/build.sh
2222
go test -v -cover ./...
2323
)
2424

25-
pytest elasticdl/python/tests elasticdl_preprocessing/tests \
26-
--cov=elasticdl/python --cov-report=xml
25+
# Run Python unittests
26+
pytest elasticdl/python/tests \
27+
elasticdl_preprocessing/tests \
28+
elasticdl_client/tests \
29+
--cov=elasticdl/python \
30+
--cov-report=xml
2731
mkdir -p ./build
2832
mv coverage.xml ./build

0 commit comments

Comments
 (0)