pre-commit run -a shellcheck (#2054)

* pre-commit run -a shellcheck

* Add copyright

Author: wangkuiyi

scripts/codestyle/cpplint_precommit.hook

@@ -1,4 +1,16 @@
 #!/bin/bash
+# Copyright 2020 The ElasticDL Authors. All rights reserved.
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
 
 TOTAL_ERRORS=0
 if [[ ! $TRAVIS_BRANCH ]]; then
@@ -7,21 +19,23 @@ if [[ ! $TRAVIS_BRANCH ]]; then
     pip install cpplint
   fi
   # diff files on local machine.
-  files=$(git diff --cached --name-status | awk 'Extra open brace or missing close brace2}')
+  files=$(git diff --cached --name-status | \
+                 awk 'Extra open brace or missing close brace2}')
 else
   # diff files between PR and latest commit on Travis CI.
   branch_ref=$(git rev-parse "$TRAVIS_BRANCH")
   head_ref=$(git rev-parse HEAD)
-  files=$(git diff --name-status $branch_ref $head_ref | awk 'Extra open brace or missing close brace2}')
+  files=$(git diff --name-status "$branch_ref" "$head_ref" | \
+                 awk 'Extra open brace or missing close brace2}')
 fi
 # The trick to remove deleted files: https://stackoverflow.com/a/2413151
 for file in $files; do
     if [[ $file =~ ^(patches/.*) ]]; then
         continue;
     else
-        cpplint --filter=-readability/fn_size $file;
-        TOTAL_ERRORS=$(expr $TOTAL_ERRORS + $?);
+        cpplint --filter=-readability/fn_size "$file";
+        TOTAL_ERRORS=$(( TOTAL_ERRORS + $? ));
     fi
 done
 
-exit $TOTAL_ERRORS
+exit "$TOTAL_ERRORS"

scripts/travis/cleanup_odps_table.sh

@@ -1,9 +1,23 @@
+#!/bin/bash
+# Copyright 2020 The ElasticDL Authors. All rights reserved.
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
 docker run --rm -it \
-    -e MAXCOMPUTE_TABLE=$MAXCOMPUTE_TABLE \
-    -e MAXCOMPUTE_PROJECT=$MAXCOMPUTE_PROJECT \
-    -e MAXCOMPUTE_AK=$ODPS_ACCESS_ID \
-    -e MAXCOMPUTE_SK=$ODPS_ACCESS_KEY \
-    -v $PWD:/work \
+    -e MAXCOMPUTE_TABLE="$MAXCOMPUTE_TABLE" \
+    -e MAXCOMPUTE_PROJECT="$MAXCOMPUTE_PROJECT" \
+    -e MAXCOMPUTE_AK="$ODPS_ACCESS_ID" \
+    -e MAXCOMPUTE_SK="$ODPS_ACCESS_KEY" \
+    -v "$PWD":/work \
     -w /work \
     elasticdl:dev \
     bash -c 'python -c '`

scripts/travis/create_odps_table.sh

@@ -1,9 +1,23 @@
+#!/bin/bash
+# Copyright 2020 The ElasticDL Authors. All rights reserved.
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
 docker run --rm -it \
-    -e MAXCOMPUTE_TABLE=$MAXCOMPUTE_TABLE \
-    -e MAXCOMPUTE_PROJECT=$MAXCOMPUTE_PROJECT \
-    -e MAXCOMPUTE_AK=$ODPS_ACCESS_ID \
-    -e MAXCOMPUTE_SK=$ODPS_ACCESS_KEY \
-    -v $PWD:/work -w /work elasticdl:dev bash \
+    -e MAXCOMPUTE_TABLE="$MAXCOMPUTE_TABLE" \
+    -e MAXCOMPUTE_PROJECT="$MAXCOMPUTE_PROJECT" \
+    -e MAXCOMPUTE_AK="$ODPS_ACCESS_ID" \
+    -e MAXCOMPUTE_SK="$ODPS_ACCESS_KEY" \
+    -v "$PWD":/work -w /work elasticdl:dev bash \
     -c 'python -c '`
     `'"from elasticdl.python.tests.test_utils import *;'`
     `'create_iris_odps_table_from_env()"'

scripts/travis/run_job.sh

@@ -1,3 +1,4 @@
+#!/bin/bash
 # Copyright 2020 The ElasticDL Authors. All rights reserved.
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -12,6 +13,7 @@
 # limitations under the License.
 
 JOB_TYPE=$1
+MAXCOMPUTE_TABLE="odps_integration_build_$TRAVIS_BUILD_NUMBER_$(date +%s)"
 
 if [[ "$JOB_TYPE" == "odps" ]] && \
 { [[ "$ODPS_ACCESS_ID" == "" ]] || \
@@ -21,26 +23,23 @@ if [[ "$JOB_TYPE" == "odps" ]] && \
 else
     echo "Running ElasticDL job: ${JOB_TYPE}"
     if [[ "$JOB_TYPE" == "odps" ]]; then
-        export MAXCOMPUTE_TABLE="odps_integration_build_"`
-            `"${TRAVIS_BUILD_NUMBER}_$(date +%s)"
+        export MAXCOMPUTE_TABLE
         bash scripts/travis/create_odps_table.sh
     fi
     PS_NUM=2
     WORKER_NUM=1
     docker run --rm -it --net=host \
-        -e MAXCOMPUTE_TABLE=$MAXCOMPUTE_TABLE \
-        -e MAXCOMPUTE_PROJECT=$MAXCOMPUTE_PROJECT \
-        -e MAXCOMPUTE_AK=$ODPS_ACCESS_ID \
-        -e MAXCOMPUTE_SK=$ODPS_ACCESS_KEY \
+        -e MAXCOMPUTE_TABLE="$MAXCOMPUTE_TABLE" \
+        -e MAXCOMPUTE_PROJECT="$MAXCOMPUTE_PROJECT" \
+        -e MAXCOMPUTE_AK="$ODPS_ACCESS_ID" \
+        -e MAXCOMPUTE_SK="$ODPS_ACCESS_KEY" \
         -v /var/run/docker.sock:/var/run/docker.sock \
-        -v $HOME/.kube:/root/.kube \
-        -v /home/$USER/.minikube/:/home/$USER/.minikube/ \
-        -v $(pwd):/work \
+        -v "$HOME"/.kube:/root/.kube \
+        -v /home/"$USER"/.minikube/:/home/"$USER"/.minikube/ \
+        -v "$PWD":/work \
         -w /work elasticdl:ci \
-        bash -c "scripts/client_test.sh \
-        ${JOB_TYPE} ${PS_NUM} ${WORKER_NUM}"
-    python3 scripts/validate_job_status.py \
-        ${JOB_TYPE} ${PS_NUM} ${WORKER_NUM}
+        bash -c "scripts/client_test.sh $JOB_TYPE $PS_NUM $WORKER_NUM"
+    python3 scripts/validate_job_status.py "$JOB_TYPE" "$PS_NUM" "$WORKER_NUM"
     if [[ "$JOB_TYPE" == "odps" ]]; then
         bash scripts/travis/cleanup_odps_table.sh
     fi

scripts/travis/start_minikube.sh

@@ -48,4 +48,4 @@ touch "$KUBECONFIG"
 sudo minikube start --vm-driver=none --kubernetes-version="$K8S_VERSION"
 kubectl cluster-info
 
-eval $(sudo minikube docker-env)
+eval "$(sudo minikube docker-env)"