Skip to content

Commit ab448c0

Browse files
authored
pre-commit run --all during CI (#2066)
* Fix the one * pre-commit run -a during CI * Install clang-format in elasticdl:dev and call make before lint
1 parent 9be324b commit ab448c0

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

.travis.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,11 @@ jobs:
4141
-f elasticdl/docker/Dockerfile
4242
--build-arg BASE_IMAGE="$BASE_IMAGE" .
4343
# Run pre-commit checks.
44-
- docker run --rm -it -v $TRAVIS_BUILD_DIR:/work -w /work
44+
- docker run --rm -it
45+
-v $TRAVIS_BUILD_DIR:/work -w /work
4546
-v $HOME/.cache:/root/.cache
46-
elasticdl:dev bash -c "scripts/pre-commit.sh"
47+
elasticdl:dev
48+
bash -c "make -f elasticdl/Makefile && pre-commit run -a"
4749
# Run a minikube cluster
4850
- bash scripts/travis/start_minikube.sh
4951
# Run unit tests not related to ODPS

docs/benchmark/data/README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,3 @@ Requirements:
1010
1. Make
1111
1. Gnuplot
1212
1. ImageMagick
13-

elasticdl/docker/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ ARG EXTRA_PYPI_INDEX=https://pypi.org/simple
66

77
RUN apt-get -qq update && \
88
apt-get -qq install -y unzip curl git software-properties-common g++ wget \
9-
shellcheck libeigen3-dev > /dev/null && \
9+
shellcheck libeigen3-dev clang-format > /dev/null && \
1010
python -m pip install --quiet --upgrade pip
1111

1212
COPY elasticdl/requirements.txt /requirements.txt

0 commit comments

Comments
 (0)