Skip to content

Commit b0c78ed

Browse files
authored
Fix annotations for Pool.recreate, Pool.status (#147)
Fixes #146. Signed-off-by: Anders Kaseorg <[email protected]>
1 parent f72abbf commit b0c78ed

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

sqlalchemy-stubs/pool/base.pyi

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,10 @@ class Pool(log.Identified):
3232
pre_ping: bool = ...,
3333
_dispatch: Optional[Any] = ...,
3434
) -> None: ...
35-
def recreate(self) -> None: ...
35+
def recreate(self) -> Pool: ...
3636
def dispose(self) -> None: ...
3737
def connect(self): ...
38-
def status(self) -> None: ...
38+
def status(self) -> str: ...
3939

4040
class _ConnectionRecord:
4141
finalize_callback: Any = ...

test/files/pool_recreate_status.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
import sqlalchemy, sqlalchemy.pool
2+
3+
engine = sqlalchemy.create_engine("postgresql://scott:tiger@localhost/test")
4+
status: str = engine.pool.status()
5+
other_pool: sqlalchemy.pool.Pool = engine.pool.recreate()

0 commit comments

Comments
 (0)