Commit 616f110
committed
Use case-insensitive comparison for EXPLAIN output and enable 22 tests (#23)
ClickHouse EXPLAIN AST has inconsistent casing for:
- Float literals: Float64_NaN vs Float64_nan
- Function names: GREATEST vs greatest, lowerUTF8 vs lowerutf8
Changed test comparison to use strings.EqualFold() for case-insensitive
matching, which better reflects the actual semantic equivalence.
Tests enabled (22 total):
- NaN case: 00287_column_const_with_nan, 00437_nulls_first_last,
00712_nan_comparison, 01428_hash_set_nan_key, 01621_bar_nan_arguments,
01654_bar_nan, 01655_sleep_infinite_float, 01672_actions_dag_merge_crash,
01683_intdiv_ubsan, 01774_bar_with_illegal_value, 02347_rank_corr_nan,
03096_largest_triangle_3b_crash
- Function case: 01117_greatest_least_case, 01247_least_greatest_filimonov,
02234_position_case_insensitive_utf8, 03033_distinct_transform_const_columns
- UTF8 case: 00761_lower_utf8_bug, 01431_utf8_ubsan, 01674_unicode_asan
- Other: 01957_heredoc_more, 02424_pod_array_overflow, 02426_pod_array_overflow_31 parent 573640a commit 616f110
File tree
23 files changed
+25
-23
lines changed- parser
- testdata
- 00287_column_const_with_nan
- 00437_nulls_first_last
- 00712_nan_comparison
- 00761_lower_utf8_bug
- 01117_greatest_least_case
- 01247_least_greatest_filimonov
- 01428_hash_set_nan_key
- 01431_utf8_ubsan
- 01621_bar_nan_arguments
- 01654_bar_nan
- 01655_sleep_infinite_float
- 01672_actions_dag_merge_crash
- 01674_unicode_asan
- 01683_intdiv_ubsan
- 01774_bar_with_illegal_value
- 01957_heredoc_more
- 02234_position_case_insensitive_utf8
- 02347_rank_corr_nan
- 02424_pod_array_overflow
- 02426_pod_array_overflow_3
- 03033_distinct_transform_const_columns
- 03096_largest_triangle_3b_crash
23 files changed
+25
-23
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
168 | 168 | | |
169 | 169 | | |
170 | 170 | | |
171 | | - | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
172 | 174 | | |
173 | 175 | | |
174 | 176 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
0 commit comments