fix: Enable strict function checking (#1405)

* fix: Enable strict function checking

Author: kyleconroy

internal/compiler/parse.go

@@ -72,7 +72,7 @@ func (c *Compiler) parseQuery(stmt ast.Node, src string, o opts.Parser) (*Query,
 	if rawSQL == "" {
 		return nil, errors.New("missing semicolon at end of file")
 	}
-	if err := validate.FuncCall(c.catalog, raw); err != nil {
+	if err := validate.FuncCall(c.catalog, c.combo, raw); err != nil {
 		return nil, err
 	}
 	name, cmd, err := metadata.Parse(strings.TrimSpace(rawSQL), c.parser.CommentSyntax())
@@ -106,7 +106,7 @@ func (c *Compiler) parseQuery(stmt ast.Node, src string, o opts.Parser) (*Query,
 	if err != nil {
 		return nil, err
 	}
-	params, err := resolveCatalogRefs(c.catalog, qc, rvs, refs, namedParams)
+	params, err := c.resolveCatalogRefs(qc, rvs, refs, namedParams)
 	if err != nil {
 		return nil, err
 	}

internal/compiler/resolve.go

@@ -18,7 +18,9 @@ func dataType(n *ast.TypeName) string {
 	}
 }
 
-func resolveCatalogRefs(c *catalog.Catalog, qc *QueryCatalog, rvs []*ast.RangeVar, args []paramRef, names map[int]string) ([]Parameter, error) {
+func (comp *Compiler) resolveCatalogRefs(qc *QueryCatalog, rvs []*ast.RangeVar, args []paramRef, names map[int]string) ([]Parameter, error) {
+	c := comp.catalog
+
 	aliasMap := map[string]*ast.TableName{}
 	// TODO: Deprecate defaultTable
 	var defaultTable *ast.TableName

internal/config/config.go

@@ -97,10 +97,11 @@ type GenKotlin struct {
 }
 
 type SQL struct {
-	Engine  Engine `json:"engine,omitempty" yaml:"engine"`
-	Schema  Paths  `json:"schema" yaml:"schema"`
-	Queries Paths  `json:"queries" yaml:"queries"`
-	Gen     SQLGen `json:"gen" yaml:"gen"`
+	Engine               Engine `json:"engine,omitempty" yaml:"engine"`
+	Schema               Paths  `json:"schema" yaml:"schema"`
+	Queries              Paths  `json:"queries" yaml:"queries"`
+	StrictFunctionChecks bool   `json:"strict_function_checks" yaml:"strict_function_checks"`
+	Gen                  SQLGen `json:"gen" yaml:"gen"`
 }
 
 type SQLGen struct {

internal/config/v_one.go

@@ -38,6 +38,7 @@ type v1PackageSettings struct {
 	OutputModelsFileName      string     `json:"output_models_file_name,omitempty" yaml:"output_models_file_name"`
 	OutputQuerierFileName     string     `json:"output_querier_file_name,omitempty" yaml:"output_querier_file_name"`
 	OutputFilesSuffix         string     `json:"output_files_suffix,omitempty" yaml:"output_files_suffix"`
+	StrictFunctionChecks      bool       `json:"strict_function_checks" yaml:"strict_function_checks"`
 }
 
 func v1ParseConfig(rd io.Reader) (Config, error) {
@@ -134,6 +135,7 @@ func (c *V1GenerateSettings) Translate() Config {
 					OutputFilesSuffix:         pkg.OutputFilesSuffix,
 				},
 			},
+			StrictFunctionChecks: pkg.StrictFunctionChecks,
 		})
 	}
 

internal/endtoend/testdata/strict_function_checks/postgresql/query.sql

@@ -0,0 +1,2 @@
+-- name: F :exec
+SELECT doesntexist();

internal/endtoend/testdata/strict_function_checks/postgresql/sqlc.json

@@ -0,0 +1,13 @@
+{
+	"version": "1",
+	"packages": [
+		{
+			"name": "querytest",
+			"path": "go",
+			"schema": "query.sql",
+			"queries": "query.sql",
+			"engine": "postgresql",
+			"strict_function_checks": true
+		}
+	]
+}

internal/endtoend/testdata/strict_function_checks/postgresql/stderr.txt

@@ -0,0 +1,2 @@
+# package querytest
+query.sql:1:1: function "doesntexist" does not exist

internal/sql/validate/func_call.go

@@ -4,15 +4,17 @@ import (
 	"errors"
 	"fmt"
 
+	"github.com/kyleconroy/sqlc/internal/config"
 	"github.com/kyleconroy/sqlc/internal/sql/ast"
 	"github.com/kyleconroy/sqlc/internal/sql/astutils"
 	"github.com/kyleconroy/sqlc/internal/sql/catalog"
 	"github.com/kyleconroy/sqlc/internal/sql/sqlerr"
 )
 
 type funcCallVisitor struct {
-	catalog *catalog.Catalog
-	err     error
+	catalog  *catalog.Catalog
+	settings config.CombinedSettings
+	err      error
 }
 
 func (v *funcCallVisitor) Visit(node ast.Node) astutils.Visitor {
@@ -59,16 +61,18 @@ func (v *funcCallVisitor) Visit(node ast.Node) astutils.Visitor {
 	}
 
 	fun, err := v.catalog.ResolveFuncCall(call)
-	if fun != nil || errors.Is(err, sqlerr.NotFound) {
+	if fun != nil {
+		return v
+	}
+	if errors.Is(err, sqlerr.NotFound) && !v.settings.Package.StrictFunctionChecks {
 		return v
 	}
-
 	v.err = err
 	return nil
 }
 
-func FuncCall(c *catalog.Catalog, n ast.Node) error {
-	visitor := funcCallVisitor{catalog: c}
+func FuncCall(c *catalog.Catalog, cs config.CombinedSettings, n ast.Node) error {
+	visitor := funcCallVisitor{catalog: c, settings: cs}
 	astutils.Walk(&visitor, n)
 	return visitor.err
 }