patches param replacement matching for double digits (#294)

* patches param replacement matching for double digits

* adds test case for 11 params with mysql

Co-authored-by: Kyle Conroy <[email protected]>

Author: cmoog

examples/booktest/mysql/models.go

@@ -25,14 +25,22 @@ INSERT INTO books (
     title,
     yr,
     available,
-    tags
+    tags,
+    is_hardcover,
+    rating,
+    front_cover_img,
+    back_cover_img
 ) VALUES (
     ?,
     ?,
     ?,
     ?,
     ?,
     ?,
+    ?,
+    ?,
+    ?, 
+    ?,
     ?
 );
 

examples/booktest/mysql/query.sql

@@ -19,7 +19,11 @@ CREATE TABLE books (
           title text NOT NULL DEFAULT '',
           yr integer NOT NULL DEFAULT 2000,
           available datetime NOT NULL DEFAULT NOW(),
-          tags text NOT NULL DEFAULT ''
+          tags text NOT NULL DEFAULT '',
+          is_hardcover BOOL NOT NULL DEFAULT 0,
+          rating decimal(13, 2),
+          front_cover_img varchar(255),
+          back_cover_img varchar(255)
           -- CONSTRAINT FOREIGN KEY (author_id) REFERENCES authors(author_id)
 ) ENGINE=InnoDB;
 

examples/booktest/mysql/query.sql.go

@@ -3,6 +3,7 @@ package mysql
 import (
 	"fmt"
 	"regexp"
+	"sort"
 	"strings"
 
 	"github.com/kyleconroy/sqlc/internal/dinosql"
@@ -174,7 +175,18 @@ func paramName(col sqlparser.ColIdent, originalName string) string {
 }
 
 func replaceParamStrs(query string, params []*Param) (string, error) {
-	for _, p := range params {
+	/*
+		To ensure that ":v1" does not replace ":v12", we need to sort
+		the params in decending order by length of the string.
+		But, the original order of the params must be preserved.
+	*/
+	paramsCopy := make([]*Param, len(params))
+	copy(paramsCopy, params)
+	sort.Slice(paramsCopy, func(i, j int) bool {
+		return len(paramsCopy[i].OriginalName) > len(paramsCopy[j].OriginalName)
+	})
+
+	for _, p := range paramsCopy {
 		re, err := regexp.Compile(fmt.Sprintf("(%v)", regexp.QuoteMeta(p.OriginalName)))
 		if err != nil {
 			return "", err