fix(compiler): correctly construct query catalog for insert-with-select queries (all engines)

Author: dennisgsmith

internal/compiler/query_catalog.go

@@ -20,7 +20,11 @@ func (comp *Compiler) buildQueryCatalog(c *catalog.Catalog, node ast.Node, embed
 	case *ast.DeleteStmt:
 		with = n.WithClause
 	case *ast.InsertStmt:
-		with = n.WithClause
+		if selectStmt, ok := n.SelectStmt.(*ast.SelectStmt); ok && selectStmt.WithClause != nil {
+			with = selectStmt.WithClause
+		} else {
+			with = n.WithClause
+		}
 	case *ast.UpdateStmt:
 		with = n.WithClause
 	case *ast.SelectStmt:

internal/endtoend/testdata/insert_cte_select/mysql/go/db.go

@@ -0,0 +1,8 @@
+-- name: CreateAuthor :exec
+insert into authors (id, name, bio)
+with potential_authors as (
+  select id, name, bio
+  from dummy
+)
+select id, name, bio
+from potential_authors;

internal/endtoend/testdata/insert_cte_select/mysql/go/models.go

@@ -0,0 +1,11 @@
+create table authors (
+  id integer primary key,
+  name text not null,
+  bio text
+);
+
+create table dummy (
+  id integer primary key,
+  name text not null,
+  bio text
+);

internal/endtoend/testdata/insert_cte_select/mysql/go/query.sql.go

@@ -0,0 +1,12 @@
+{
+  "version": "1",
+  "packages": [
+    {
+      "engine": "mysql",
+      "path": "go",
+      "name": "querytest",
+      "schema": "schema.sql",
+      "queries": "query.sql"
+    }
+  ]
+}