Skip to content

Commit 805759d

Browse files
authored
fix(engine/mysql): Fix missing binds in ORDER BY (#1273)
1 parent 4663aab commit 805759d

File tree

11 files changed

+332
-9
lines changed

11 files changed

+332
-9
lines changed

internal/endtoend/testdata/order_by_binds/mysql/go/db.go

Lines changed: 29 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/endtoend/testdata/order_by_binds/mysql/go/models.go

Lines changed: 13 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/endtoend/testdata/order_by_binds/mysql/go/query.sql.go

Lines changed: 71 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
CREATE TABLE authors (
2+
id BIGINT PRIMARY KEY,
3+
name text NOT NULL,
4+
bio text
5+
);
6+
7+
-- name: ListAuthorsColumnSort :many
8+
SELECT * FROM authors
9+
WHERE id > sqlc.arg(min_id)
10+
ORDER BY CASE WHEN sqlc.arg(sort_column) = 'name' THEN name END;
11+
12+
-- name: ListAuthorsNameSort :many
13+
SELECT * FROM authors
14+
WHERE id > sqlc.arg(min_id)
15+
ORDER BY name ASC;
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
{
2+
"version": "1",
3+
"packages": [
4+
{
5+
"path": "go",
6+
"engine": "mysql",
7+
"name": "querytest",
8+
"schema": "query.sql",
9+
"queries": "query.sql"
10+
}
11+
]
12+
}

internal/endtoend/testdata/order_by_binds/postgresql/go/db.go

Lines changed: 29 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/endtoend/testdata/order_by_binds/postgresql/go/models.go

Lines changed: 13 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/endtoend/testdata/order_by_binds/postgresql/go/query.sql.go

Lines changed: 71 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
CREATE TABLE authors (
2+
id BIGSERIAL PRIMARY KEY,
3+
name text NOT NULL,
4+
bio text
5+
);
6+
7+
-- name: ListAuthorsColumnSort :many
8+
SELECT * FROM authors
9+
WHERE id > sqlc.arg(min_id)
10+
ORDER BY CASE WHEN sqlc.arg(sort_column) = 'name' THEN name END;
11+
12+
-- name: ListAuthorsNameSort :many
13+
SELECT * FROM authors
14+
WHERE id > sqlc.arg(min_id)
15+
ORDER BY name ASC;
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
{
2+
"version": "1",
3+
"packages": [
4+
{
5+
"path": "go",
6+
"engine": "postgresql",
7+
"name": "querytest",
8+
"schema": "query.sql",
9+
"queries": "query.sql"
10+
}
11+
]
12+
}

0 commit comments

Comments
 (0)