Skip to content

Commit 863c496

Browse files
committed
fix(postgresql): Support all DROP statements
1 parent 55efafc commit 863c496

File tree

7 files changed

+101
-0
lines changed

7 files changed

+101
-0
lines changed

internal/endtoend/testdata/ddl_drop_trigger/postgresql/pgx/v5/go/db.go

Lines changed: 32 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/endtoend/testdata/ddl_drop_trigger/postgresql/pgx/v5/go/models.go

Lines changed: 13 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/endtoend/testdata/ddl_drop_trigger/postgresql/pgx/v5/go/query.sql.go

Lines changed: 28 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
-- name: DropTrigger :exec
2+
DROP TRIGGER IF EXISTS my_trigger ON accounts;
3+
4+
-- name: DropEventTrigger :exec
5+
DROP EVENT TRIGGER IF EXISTS my_event_trigger;
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
CREATE TABLE accounts (
2+
name text
3+
);
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
{
2+
"version": "1",
3+
"packages": [
4+
{
5+
"path": "go",
6+
"engine": "postgresql",
7+
"sql_package": "pgx/v5",
8+
"name": "querytest",
9+
"schema": "schema.sql",
10+
"queries": "query.sql"
11+
}
12+
]
13+
}

internal/engine/postgresql/parse.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -601,7 +601,14 @@ func translate(node *nodes.Node) (ast.Node, error) {
601601
}
602602
return drop, nil
603603

604+
default:
605+
drop := &ast.DropStmt{
606+
MissingOk: n.MissingOk,
607+
}
608+
return drop, nil
609+
604610
}
611+
605612
return nil, errSkip
606613

607614
case *nodes.Node_RenameStmt:

0 commit comments

Comments
 (0)