fix(mysql): Variables not resolving in ORDER BY statements (#3115)

Author: seanlaff

internal/endtoend/testdata/order_by_binds/mysql/go/query.sql.go

@@ -3,6 +3,10 @@ SELECT  * FROM authors
 WHERE   id > sqlc.arg(min_id) 
 ORDER   BY CASE WHEN sqlc.arg(sort_column) = 'name' THEN name END;
 
+-- name: ListAuthorsColumnSortFnWtihArg :many
+SELECT  * FROM authors
+ORDER   BY MOD(id, sqlc.arg(mod_arg));
+
 -- name: ListAuthorsNameSort :many
 SELECT  * FROM authors
 WHERE   id > sqlc.arg(min_id)

internal/endtoend/testdata/order_by_binds/mysql/query.sql

@@ -3,6 +3,10 @@ SELECT  * FROM authors
 WHERE   id > sqlc.arg(min_id) 
 ORDER   BY CASE WHEN sqlc.arg(sort_column) = 'name' THEN name END;
 
+-- name: ListAuthorsColumnSortFnWtihArg :many
+SELECT  * FROM authors
+ORDER   BY MOD(id, $1);
+
 -- name: ListAuthorsNameSort :many
 SELECT  * FROM authors
 WHERE   id > sqlc.arg(min_id)

internal/endtoend/testdata/order_by_binds/postgresql/go/query.sql.go

@@ -1025,18 +1025,7 @@ func (c *cc) convertOrderByClause(n *pcast.OrderByClause) ast.Node {
 	}
 	list := &ast.List{Items: []ast.Node{}}
 	for _, item := range n.Items {
-		switch item.Expr.(type) {
-		case *pcast.CaseExpr:
-			list.Items = append(list.Items, &ast.CaseWhen{
-				Expr:     c.convert(item.Expr),
-				Location: item.Expr.OriginTextPosition(),
-			})
-		case *pcast.ColumnNameExpr:
-			list.Items = append(list.Items, &ast.CaseExpr{
-				Xpr:      c.convert(item.Expr),
-				Location: item.Expr.OriginTextPosition(),
-			})
-		}
+		list.Items = append(list.Items, c.convert(item.Expr))
 	}
 	return list
 }