compiler: temp fix for typecast function parameters (#530)

In cases where a FuncCall has a TypeCast node as an
argument, resolveCatalogRefs would erroneously output
two parameters for that argument instead of one.

This fix eliminates the duplicate param and allows queries
with typecast function args to compile, but it loses track
of the argument's connection with the function called. This
means the parameters use the generic ColumnN names even when
the function has named parameters.

A future refactor of resolveCatalogRefs to better address
function calls will be necessary to address the name issue.

(this only edits the experimental package and  does not fix
the old dinosql compiler)

Closes #520

Co-authored-by: Kyle Conroy <[email protected]>

Author: maxhawkins

internal/compiler/resolve.go

@@ -193,6 +193,14 @@ func resolveCatalogRefs(c *catalog.Catalog, rvs []*pg.RangeVar, args []paramRef,
 					if inode.Number != ref.ref.Number {
 						continue
 					}
+				case *pg.TypeCast:
+					pr, ok := inode.Arg.(*pg.ParamRef)
+					if !ok {
+						continue
+					}
+					if pr.Number != ref.ref.Number {
+						continue
+					}
 				case *pg.NamedArgExpr:
 					pr, ok := inode.Arg.(*pg.ParamRef)
 					if !ok {

internal/endtoend/testdata/func_args_typecast/endtoend.json

@@ -0,0 +1,3 @@
+{
+  "experimental_parser_only": true
+}

internal/endtoend/testdata/func_args_typecast/go/db.go

@@ -0,0 +1,8 @@
+CREATE FUNCTION plus(a integer, b integer) RETURNS integer AS $$
+    BEGIN
+        RETURN a + b;
+    END;
+$$ LANGUAGE plpgsql;
+
+-- name: PlusPositionalCast :one
+SELECT plus($1, $2::INTEGER);

internal/endtoend/testdata/func_args_typecast/go/models.go

@@ -0,0 +1,11 @@
+{
+  "version": "1",
+  "packages": [
+    {
+      "path": "go",
+      "name": "querytest",
+      "schema": "query.sql",
+      "queries": "query.sql"
+    }
+  ]
+}