Fix CI test workflows to work properly

gfx · gfx · commit 21af80d66412 · 2025-09-24T10:34:34.000+09:00
- Add baseline schemas for all database tests
- Use baseline-schema-file parameter to enable comparison mode
- Skip PR comment posting when baseline file is explicitly provided
- Fix SQLite schema syntax (remove IF NOT EXISTS, use TEXT for timestamps)
- Add MSSQL test workflow with 2019 version
- Tests now properly compare baseline vs desired schemas
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -80,11 +80,24 @@ jobs:
           CREATE INDEX IF NOT EXISTS idx_posts_published_at ON posts(published_at);
           EOF
 
+      - name: Create baseline schema
+        run: |
+          cat > baseline.sql <<EOF
+          CREATE TABLE IF NOT EXISTS users (
+              id SERIAL PRIMARY KEY,
+              username VARCHAR(50) UNIQUE NOT NULL,
+              created_at TIMESTAMP DEFAULT CURRENT_TIMESTAMP
+          );
+          EOF
+
       - name: Test PostgreSQL action (dry-run)
         uses: ./
+        env:
+          GITHUB_EVENT_NAME: push
         with:
           command: psqldef
           version: latest
+          baseline-schema-file: baseline.sql
           schema-file: schema.sql
           pg-user: postgres
           pg-password: postgres
@@ -136,11 +149,24 @@ jobs:
           );
           EOF
 
+      - name: Create baseline schema
+        run: |
+          cat > baseline.sql <<EOF
+          CREATE TABLE IF NOT EXISTS users (
+              id INT AUTO_INCREMENT PRIMARY KEY,
+              username VARCHAR(50) UNIQUE NOT NULL,
+              created_at TIMESTAMP DEFAULT CURRENT_TIMESTAMP
+          );
+          EOF
+
       - name: Test MySQL action
         uses: ./
+        env:
+          GITHUB_EVENT_NAME: push
         with:
           command: mysqldef
           version: latest
+          baseline-schema-file: baseline.sql
           schema-file: schema.sql
           mysql-user: root
           mysql-password: root
@@ -158,30 +184,123 @@ jobs:
       - name: Create SQLite test schema file
         run: |
           cat > schema.sql <<EOF
-          CREATE TABLE IF NOT EXISTS users (
+          CREATE TABLE users (
               id INTEGER PRIMARY KEY AUTOINCREMENT,
               username TEXT UNIQUE NOT NULL,
               email TEXT UNIQUE NOT NULL,
-              created_at TIMESTAMP DEFAULT CURRENT_TIMESTAMP
+              created_at TEXT DEFAULT CURRENT_TIMESTAMP
           );
 
-          CREATE TABLE IF NOT EXISTS posts (
+          CREATE TABLE posts (
               id INTEGER PRIMARY KEY AUTOINCREMENT,
               user_id INTEGER REFERENCES users(id),
               title TEXT NOT NULL,
               content TEXT,
-              published_at TIMESTAMP,
-              created_at TIMESTAMP DEFAULT CURRENT_TIMESTAMP
+              published_at TEXT,
+              created_at TEXT DEFAULT CURRENT_TIMESTAMP
           );
 
-          CREATE INDEX IF NOT EXISTS idx_posts_user_id ON posts(user_id);
-          CREATE INDEX IF NOT EXISTS idx_posts_published_at ON posts(published_at);
+          CREATE INDEX idx_posts_user_id ON posts(user_id);
+          CREATE INDEX idx_posts_published_at ON posts(published_at);
+          EOF
+
+      - name: Create baseline schema
+        run: |
+          cat > baseline.sql <<EOF
+          CREATE TABLE users (
+              id INTEGER PRIMARY KEY AUTOINCREMENT,
+              username TEXT UNIQUE NOT NULL,
+              created_at TEXT DEFAULT CURRENT_TIMESTAMP
+          );
           EOF
 
       - name: Test SQLite action
         uses: ./
+        env:
+          GITHUB_EVENT_NAME: push
         with:
           command: sqlite3def
           version: latest
+          baseline-schema-file: baseline.sql
           schema-file: schema.sql
           sqlite-database: test.db
+
+  test-mssql:
+    runs-on: ubuntu-latest
+    continue-on-error: true
+
+    services:
+      sqlserver:
+        image: mcr.microsoft.com/mssql/server:2019-CU32-ubuntu-20.04
+        env:
+          ACCEPT_EULA: Y
+          SA_PASSWORD: YourStrong@Passw0rd
+          MSSQL_PID: Developer
+        options: >-
+          --health-cmd "/opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P 'YourStrong@Passw0rd' -Q 'SELECT 1'"
+          --health-interval 10s
+          --health-timeout 5s
+          --health-retries 10
+        ports:
+          - 1433:1433
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v5
+
+      - name: Wait for SQL Server
+        run: |
+          for i in {1..30}; do
+            /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P 'YourStrong@Passw0rd' -Q 'SELECT 1' && break
+            echo "Waiting for SQL Server..."
+            sleep 2
+          done
+          /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P 'YourStrong@Passw0rd' -Q "CREATE DATABASE testdb"
+
+      - name: Create test schema file
+        run: |
+          cat > schema.sql <<EOF
+          CREATE TABLE users (
+              id INT IDENTITY(1,1) PRIMARY KEY,
+              username NVARCHAR(50) UNIQUE NOT NULL,
+              email NVARCHAR(100) UNIQUE NOT NULL,
+              created_at DATETIME2 DEFAULT GETDATE()
+          );
+
+          CREATE TABLE posts (
+              id INT IDENTITY(1,1) PRIMARY KEY,
+              user_id INT FOREIGN KEY REFERENCES users(id),
+              title NVARCHAR(200) NOT NULL,
+              content NTEXT,
+              published_at DATETIME2,
+              created_at DATETIME2 DEFAULT GETDATE()
+          );
+
+          CREATE INDEX idx_posts_user_id ON posts(user_id);
+          CREATE INDEX idx_posts_published_at ON posts(published_at);
+          EOF
+
+      - name: Create baseline schema
+        run: |
+          cat > baseline.sql <<EOF
+          CREATE TABLE users (
+              id INT IDENTITY(1,1) PRIMARY KEY,
+              username NVARCHAR(50) UNIQUE NOT NULL,
+              created_at DATETIME2 DEFAULT GETDATE()
+          );
+          EOF
+
+      - name: Test MSSQL action
+        uses: ./
+        env:
+          GITHUB_EVENT_NAME: push
+        with:
+          command: mssqldef
+          version: latest
+          baseline-schema-file: baseline.sql
+          schema-file: schema.sql
+          mssql-user: sa
+          mssql-password: YourStrong@Passw0rd
+          mssql-host: localhost
+          mssql-port: 1433
+          mssql-database: testdb
diff --git a/AGENTS.md b/AGENTS.md
@@ -0,0 +1 @@
+CLAUDE.md
diff --git a/CLAUDE.md b/CLAUDE.md
@@ -0,0 +1,9 @@
+This is a GitHub Action project implemented in TypeScript.
+
+## General Rules
+
+*
+
+## Before commit
+
+* Run `npm run all`, `git add dist`, and then commit the changes.
diff --git a/dist/index.js b/dist/index.js
@@ -268,7 +268,10 @@ async function run() {
         core.info(`Downloaded ${command} to ${binaryPath}`);
         const config = getCommandConfig(command);
         const context = github.context;
-        if (context.eventName === "pull_request" || baselineSchemaFile) {
+        // Use baseline comparison when:
+        // 1. It's a pull request event AND no baseline file is provided
+        // 2. A baseline file is explicitly provided
+        if ((context.eventName === "pull_request" && !baselineSchemaFile) || baselineSchemaFile) {
             let actualBaselineFile = baselineSchemaFile;
             if (!actualBaselineFile) {
                 const baseBranch = context.payload.pull_request.base.ref;
@@ -295,11 +298,17 @@ async function run() {
             if (output.trim()) {
                 core.info("Schema changes detected:");
                 core.info(output);
-                await createComment(output);
+                // Only create comment for actual PR events
+                if (context.eventName === "pull_request" && !baselineSchemaFile) {
+                    await createComment(output);
+                }
             }
             else {
                 core.info("No schema changes detected");
-                await createComment("No schema changes detected.");
+                // Only create comment for actual PR events
+                if (context.eventName === "pull_request" && !baselineSchemaFile) {
+                    await createComment("No schema changes detected.");
+                }
             }
             if (!baselineSchemaFile && actualBaselineFile && actualBaselineFile !== "" && fs.existsSync(actualBaselineFile)) {
                 fs.unlinkSync(actualBaselineFile);
diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/src/main.ts b/src/main.ts
@@ -263,7 +263,10 @@ async function run(): Promise<void> {
 
         const context = github.context;
 
-        if (context.eventName === "pull_request" || baselineSchemaFile) {
+        // Use baseline comparison when:
+        // 1. It's a pull request event AND no baseline file is provided
+        // 2. A baseline file is explicitly provided
+        if ((context.eventName === "pull_request" && !baselineSchemaFile) || baselineSchemaFile) {
             let actualBaselineFile = baselineSchemaFile;
 
             if (!actualBaselineFile) {
@@ -294,10 +297,16 @@ async function run(): Promise<void> {
             if (output.trim()) {
                 core.info("Schema changes detected:");
                 core.info(output);
-                await createComment(output);
+                // Only create comment for actual PR events
+                if (context.eventName === "pull_request" && !baselineSchemaFile) {
+                    await createComment(output);
+                }
             } else {
                 core.info("No schema changes detected");
-                await createComment("No schema changes detected.");
+                // Only create comment for actual PR events
+                if (context.eventName === "pull_request" && !baselineSchemaFile) {
+                    await createComment("No schema changes detected.");
+                }
             }
 
             if (!baselineSchemaFile && actualBaselineFile && actualBaselineFile !== "" && fs.existsSync(actualBaselineFile)) {
